From: Pavel Begunkov <[email protected]>
To: Dan Carpenter <[email protected]>
Cc: [email protected]
Subject: Re: [bug report] io_uring: return iovec from __io_import_iovec
Date: Mon, 8 Nov 2021 15:19:21 +0000 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <20211108134937.GA2863@kili>
On 11/8/21 13:49, Dan Carpenter wrote:
> Hello Pavel Begunkov,
>
> The patch caa8fe6e86fd: "io_uring: return iovec from
> __io_import_iovec" from Oct 15, 2021, leads to the following Smatch
> static checker warning:
>
> fs/io_uring.c:3218 __io_import_iovec()
> warn: passing zero to 'ERR_PTR'
>
[...]
> 3188
> 3189 BUILD_BUG_ON(ERR_PTR(0) != NULL);
>
> This is super paranoid. :P
A bit, but gives an idea about assumptions
> 3209 ret = import_single_range(rw, buf, sqe_len, s->fast_iov, iter);
> 3210 return ERR_PTR(ret);
if (ret)
return ERR_PTR(ret);
return NULL;
How about this? I have some hope in compilers, should be
optimised out
--
Pavel Begunkov
next prev parent reply other threads:[~2021-11-08 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 13:49 [bug report] io_uring: return iovec from __io_import_iovec Dan Carpenter
2021-11-08 15:19 ` Pavel Begunkov [this message]
2021-11-08 15:30 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox