From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 592E2C11D2F for ; Mon, 24 Feb 2020 15:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2106A20828 for ; Mon, 24 Feb 2020 15:58:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HjO/OPsc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727979AbgBXP6i (ORCPT ); Mon, 24 Feb 2020 10:58:38 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40354 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727359AbgBXP6h (ORCPT ); Mon, 24 Feb 2020 10:58:37 -0500 Received: by mail-wr1-f65.google.com with SMTP id t3so10977323wru.7 for ; Mon, 24 Feb 2020 07:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to; bh=iO27png7hoKDOt2Wzp+tqN2OzYVeupYWzdGj6zSG3rI=; b=HjO/OPscuBQjRkDWlTO/o30+HTxLp+3wU3V0gup600z/ttd80EKWi3CPw3za2VBHmG BkU7SFar8Xlh5gOsFVXM0jVLDWEVl9raPWgi05AE+wzFO1RfjZDJFO07N3JzJDqs6GaW mZMlToAFNzxUKX1QBK8qqYyDj+crbNy7XOaHBkm+v7vGcYq5zTJq5J35gkiMUyP9/hEa NvUr9ns0A0uTgnnlevbDWlckRtHwSzZ5xM1zDk7f5+20rnYa3jdNzHOvPvpd/uaXaHx4 AY3gOxzN2UYQ56LYmFAbkZvaw6upEIuDJQYqfeo3wzXVO7ck5kZ0KagoNbR2eNsRb7Bj f73g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to; bh=iO27png7hoKDOt2Wzp+tqN2OzYVeupYWzdGj6zSG3rI=; b=UshYfUHdY+L1bi5F1cUSqlcGW5SxuzKlhwgtadk3X0X5SSWYvzpEJYUojtjLoOBFxt nuE7VovP5BOx1ltocTr2oGT95Np6HFsRFI+vrMjIoX9TykMLEmAiuxfumNOv3XqnxyMj fGA/XYIw2CXE+O0s/3JpPvipBLSF06vfTxdOBqWBxQNW9hzIO7uw5I5fJEjkPNv0hC8Y AFhVwbBCMClqQ6eVLnzrd0cxBL0Yf7XBf6TVKLWb/oquS+fqCXexYAb5nWRXVYGFR3Oo dI71JiwJ/xe8354I9mFgdZRsa0uVXkhKm52dogohndwYTffQfhDCztzdliq773biwFZQ 7qLg== X-Gm-Message-State: APjAAAXZ/T6dxKYRh+7qfvrLWpVvPwtXrrAPliOg7gBmhymkQhirN4dC XSn9d7DcDpZPHF5j43obCUK78gK+ X-Google-Smtp-Source: APXvYqwWVRJgx6c5Qk1EJMJ+cA40kIuuUeRSTJAc7CJVmw+VHsbWrGp/PPq7HF3hvhTLFSp9eIUjJw== X-Received: by 2002:a5d:6692:: with SMTP id l18mr65239140wru.382.1582559915038; Mon, 24 Feb 2020 07:58:35 -0800 (PST) Received: from [192.168.43.177] ([109.126.137.65]) by smtp.gmail.com with ESMTPSA id o2sm18269008wmh.46.2020.02.24.07.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2020 07:58:34 -0800 (PST) Subject: Re: [PATCH v3 2/3] io_uring: don't do full *prep_worker() from io-wq To: Jens Axboe , io-uring@vger.kernel.org References: <8c439182-008b-dfe6-82e7-487c849a2092@kernel.dk> <1f2860f8-aff5-972d-a399-6b0f10fd2373@gmail.com> From: Pavel Begunkov Autocrypt: addr=asml.silence@gmail.com; prefer-encrypt=mutual; keydata= mQINBFmKBOQBEAC76ZFxLAKpDw0bKQ8CEiYJRGn8MHTUhURL02/7n1t0HkKQx2K1fCXClbps bdwSHrhOWdW61pmfMbDYbTj6ZvGRvhoLWfGkzujB2wjNcbNTXIoOzJEGISHaPf6E2IQx1ik9 6uqVkK1OMb7qRvKH0i7HYP4WJzYbEWVyLiAxUj611mC9tgd73oqZ2pLYzGTqF2j6a/obaqha +hXuWTvpDQXqcOZJXIW43atprH03G1tQs7VwR21Q1eq6Yvy2ESLdc38EqCszBfQRMmKy+cfp W3U9Mb1w0L680pXrONcnlDBCN7/sghGeMHjGKfNANjPc+0hzz3rApPxpoE7HC1uRiwC4et83 CKnncH1l7zgeBT9Oa3qEiBlaa1ZCBqrA4dY+z5fWJYjMpwI1SNp37RtF8fKXbKQg+JuUjAa9 Y6oXeyEvDHMyJYMcinl6xCqCBAXPHnHmawkMMgjr3BBRzODmMr+CPVvnYe7BFYfoajzqzq+h EyXSl3aBf0IDPTqSUrhbmjj5OEOYgRW5p+mdYtY1cXeK8copmd+fd/eTkghok5li58AojCba jRjp7zVOLOjDlpxxiKhuFmpV4yWNh5JJaTbwCRSd04sCcDNlJj+TehTr+o1QiORzc2t+N5iJ NbILft19Izdn8U39T5oWiynqa1qCLgbuFtnYx1HlUq/HvAm+kwARAQABtDFQYXZlbCBCZWd1 bmtvdiAoc2lsZW5jZSkgPGFzbWwuc2lsZW5jZUBnbWFpbC5jb20+iQJOBBMBCAA4FiEE+6Ju PTjTbx479o3OWt5b1Glr+6UFAlmKBOQCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQ Wt5b1Glr+6WxZA//QueaKHzgdnOikJ7NA/Vq8FmhRlwgtP0+E+w93kL+ZGLzS/cUCIjn2f4Q Mcutj2Neg0CcYPX3b2nJiKr5Vn0rjJ/suiaOa1h1KzyNTOmxnsqE5fmxOf6C6x+NKE18I5Jy xzLQoktbdDVA7JfB1itt6iWSNoOTVcvFyvfe5ggy6FSCcP+m1RlR58XxVLH+qlAvxxOeEr/e aQfUzrs7gqdSd9zQGEZo0jtuBiB7k98t9y0oC9Jz0PJdvaj1NZUgtXG9pEtww3LdeXP/TkFl HBSxVflzeoFaj4UAuy8+uve7ya/ECNCc8kk0VYaEjoVrzJcYdKP583iRhOLlZA6HEmn/+Gh9 4orG67HNiJlbFiW3whxGizWsrtFNLsSP1YrEReYk9j1SoUHHzsu+ZtNfKuHIhK0sU07G1OPN 2rDLlzUWR9Jc22INAkhVHOogOcc5ajMGhgWcBJMLCoi219HlX69LIDu3Y34uIg9QPZIC2jwr 24W0kxmK6avJr7+n4o8m6sOJvhlumSp5TSNhRiKvAHB1I2JB8Q1yZCIPzx+w1ALxuoWiCdwV M/azguU42R17IuBzK0S3hPjXpEi2sK/k4pEPnHVUv9Cu09HCNnd6BRfFGjo8M9kZvw360gC1 reeMdqGjwQ68o9x0R7NBRrtUOh48TDLXCANAg97wjPoy37dQE7e5Ag0EWYoE5AEQAMWS+aBV IJtCjwtfCOV98NamFpDEjBMrCAfLm7wZlmXy5I6o7nzzCxEw06P2rhzp1hIqkaab1kHySU7g dkpjmQ7Jjlrf6KdMP87mC/Hx4+zgVCkTQCKkIxNE76Ff3O9uTvkWCspSh9J0qPYyCaVta2D1 Sq5HZ8WFcap71iVO1f2/FEHKJNz/YTSOS/W7dxJdXl2eoj3gYX2UZNfoaVv8OXKaWslZlgqN jSg9wsTv1K73AnQKt4fFhscN9YFxhtgD/SQuOldE5Ws4UlJoaFX/yCoJL3ky2kC0WFngzwRF Yo6u/KON/o28yyP+alYRMBrN0Dm60FuVSIFafSqXoJTIjSZ6olbEoT0u17Rag8BxnxryMrgR dkccq272MaSS0eOC9K2rtvxzddohRFPcy/8bkX+t2iukTDz75KSTKO+chce62Xxdg62dpkZX xK+HeDCZ7gRNZvAbDETr6XI63hPKi891GeZqvqQVYR8e+V2725w+H1iv3THiB1tx4L2bXZDI DtMKQ5D2RvCHNdPNcZeldEoJwKoA60yg6tuUquvsLvfCwtrmVI2rL2djYxRfGNmFMrUDN1Xq F3xozA91q3iZd9OYi9G+M/OA01husBdcIzj1hu0aL+MGg4Gqk6XwjoSxVd4YT41kTU7Kk+/I 5/Nf+i88ULt6HanBYcY/+Daeo/XFABEBAAGJAjYEGAEIACAWIQT7om49ONNvHjv2jc5a3lvU aWv7pQUCWYoE5AIbDAAKCRBa3lvUaWv7pfmcEACKTRQ28b1y5ztKuLdLr79+T+LwZKHjX++P 4wKjEOECCcB6KCv3hP+J2GCXDOPZvdg/ZYZafqP68Yy8AZqkfa4qPYHmIdpODtRzZSL48kM8 LRzV8Rl7J3ItvzdBRxf4T/Zseu5U6ELiQdCUkPGsJcPIJkgPjO2ROG/ZtYa9DvnShNWPlp+R uPwPccEQPWO/NP4fJl2zwC6byjljZhW5kxYswGMLBwb5cDUZAisIukyAa8Xshdan6C2RZcNs rB3L7vsg/R8UCehxOH0C+NypG2GqjVejNZsc7bgV49EOVltS+GmGyY+moIzxsuLmT93rqyII 5rSbbcTLe6KBYcs24XEoo49Zm9oDA3jYvNpeYD8rDcnNbuZh9kTgBwFN41JHOPv0W2FEEWqe JsCwQdcOQ56rtezdCJUYmRAt3BsfjN3Jn3N6rpodi4Dkdli8HylM5iq4ooeb5VkQ7UZxbCWt UVMKkOCdFhutRmYp0mbv2e87IK4erwNHQRkHUkzbsuym8RVpAZbLzLPIYK/J3RTErL6Z99N2 m3J6pjwSJY/zNwuFPs9zGEnRO4g0BUbwGdbuvDzaq6/3OJLKohr5eLXNU3JkT+3HezydWm3W OPhauth7W0db74Qd49HXK0xe/aPrK+Cp+kU1HRactyNtF8jZQbhMCC8vMGukZtWaAwpjWiiH bA== Message-ID: Date: Mon, 24 Feb 2020 18:57:51 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ma96D3LtUIRWi7R3Ydl8BOpL0Iv0EkD7k" Sender: io-uring-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ma96D3LtUIRWi7R3Ydl8BOpL0Iv0EkD7k Content-Type: multipart/mixed; boundary="l0OTMWyJOJk8dnCw2O7YBUeUou4R3y3FQ"; protected-headers="v1" From: Pavel Begunkov To: Jens Axboe , io-uring@vger.kernel.org Message-ID: Subject: Re: [PATCH v3 2/3] io_uring: don't do full *prep_worker() from io-wq References: <8c439182-008b-dfe6-82e7-487c849a2092@kernel.dk> <1f2860f8-aff5-972d-a399-6b0f10fd2373@gmail.com> In-Reply-To: --l0OTMWyJOJk8dnCw2O7YBUeUou4R3y3FQ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 24/02/2020 18:57, Jens Axboe wrote: > On 2/24/20 8:48 AM, Pavel Begunkov wrote: >> On 24/02/2020 18:30, Jens Axboe wrote: >>> On 2/24/20 1:30 AM, Pavel Begunkov wrote: >>>> io_prep_async_worker() called io_wq_assign_next() do many useless ch= ecks: >>>> io_req_work_grab_env() was already called during prep, and @do_hashe= d >>>> is not ever used. Add io_prep_next_work() -- simplified version, tha= t >>>> can be called io-wq. >>>> >>>> Signed-off-by: Pavel Begunkov >>>> --- >>>> fs/io_uring.c | 13 ++++++++++++- >>>> 1 file changed, 12 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/fs/io_uring.c b/fs/io_uring.c >>>> index 819661f49023..3003e767ced3 100644 >>>> --- a/fs/io_uring.c >>>> +++ b/fs/io_uring.c >>>> @@ -955,6 +955,17 @@ static inline void io_req_work_drop_env(struct = io_kiocb *req) >>>> } >>>> } >>>> =20 >>>> +static inline void io_prep_next_work(struct io_kiocb *req, >>>> + struct io_kiocb **link) >>>> +{ >>>> + const struct io_op_def *def =3D &io_op_defs[req->opcode]; >>>> + >>>> + if (!(req->flags & REQ_F_ISREG) && def->unbound_nonreg_file) >>>> + req->work.flags |=3D IO_WQ_WORK_UNBOUND; >>> >>> Extra tab? >> >> Yep. Would resending [2/3] be enough? >=20 > No need, I just did a hand edit of the patch before applying. Great, appreciate that --=20 Pavel Begunkov --l0OTMWyJOJk8dnCw2O7YBUeUou4R3y3FQ-- --Ma96D3LtUIRWi7R3Ydl8BOpL0Iv0EkD7k Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+6JuPTjTbx479o3OWt5b1Glr+6UFAl5T8n8ACgkQWt5b1Glr +6XFlQ/+Ncs64A6jKeyp7inzyZI52ibLa3COW4Ts+oJjc29gFPhjiPICXlYZdKI5 YysxaLSpOPV5QdkXByTyZyRY+KLvs6UIqmd8URwVwTqzUQFFwp/Mcov+1rF++FGu bXLKedtCdrHkm4mNUvq0Xtn/JQggb8nUpjNyWw/77W/Q60yYp02TYkNMSi3xJS82 NQvRmUrB+X+NYOWABYvXSRGjsLye+SF4QpFGPI0UfvhXnPgIIvuqtkeZ9c2O8/e1 IUsI5OfFD2b6eK0xErUxzHDtOLfnUFjH/0VSXOy14HUT3g1eTzE4XsUoCTixDlrX K4OvefdECNJW1DWytDn7G0RNL4IvTrACPlOLVQgW8IIcWbtwqR+kLB8GYlYBKNBB BLwaxX6oGt+6cg9+hKYJ/pFackJC5NtEeLtgvXPloxHbbW8CFRiYhWMhvnz3Cytc 3NP564stJ5Y26Om1umlhQIFsaptaQT1uT1dqZfm0krhAxnNhXKFx7Ks6TA95DfbX VHXfL5GTOUklHXw0sWMPM6fZJntvFq9vzg/m5NVeLXbnRxTT2PT+nfFvYernXfDF 9rK6HpDMTOMOpyansUOzIEH+kPkEQU2PZoLEOZTHtJIUiJhsNLFS9wc27DLXqc45 SMQLAaYG/MsLXylcfceLP3ugQGQIXdpeQFKYp3XcylpOm+whPjM= =XPxz -----END PGP SIGNATURE----- --Ma96D3LtUIRWi7R3Ydl8BOpL0Iv0EkD7k--