From: Jens Axboe <[email protected]>
To: Dylan Yudaken <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Cc: [email protected]
Subject: Re: [PATCH for-next] io_uring: do not double call_rcu with eventfd
Date: Thu, 1 Sep 2022 09:20:44 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 9/1/22 3:32 AM, Dylan Yudaken wrote:
> It is not allowed to use call_rcu twice with the same rcu head. This could
> have happened with multiple signals occurring concurrently.
>
> Instead keep track of ops in a bitset and only queue up the call if it is
> not already queued up.
>
> The refcounting is still required since as far as I can tell there is
> otherwise no protection from a call to io_eventfd_ops being started and
> before it completes another call being started.
>
> Fixes: "io_uring: signal registered eventfd to process deferred task work"
> Signed-off-by: Dylan Yudaken <[email protected]>
> ---
>
> Note I did not put a hash in the Fixes tag as it has not yet been merged.
> You could also just merge it into that commit if you like.
I folded it into that commit, thanks!
--
Jens Axboe
prev parent reply other threads:[~2022-09-01 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 9:32 [PATCH for-next] io_uring: do not double call_rcu with eventfd Dylan Yudaken
2022-09-01 15:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox