From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, Dylan Yudaken <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH 0/2] io_uring: fix locking in __io_run_local_work
Date: Thu, 27 Oct 2022 09:57:46 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 10/27/22 9:52 AM, Jens Axboe wrote:
> On Thu, 27 Oct 2022 07:44:27 -0700, Dylan Yudaken wrote:
>> If locked was not set in __io_run_local_work, but some task work managed
>> to lock the context, it would leave things locked indefinitely. Fix that
>> by passing the pointer in.
>>
>> Patch 1 is a tiny cleanup to simplify things
>> Patch 2 is the fix
>>
>> [...]
>
> Applied, thanks!
>
> [1/2] io_uring: use io_run_local_work_locked helper
> commit: 8de11cdc96bf58b324c59a28512eb9513fd02553
> [2/2] io_uring: unlock if __io_run_local_work locked inside
> commit: b3026767e15b488860d4bbf1649d69612bab2c25
I made the WARN_ON() -> WARN_ON_ONCE() edit and added a small
comment as well, while applying.
--
Jens Axboe
prev parent reply other threads:[~2022-10-27 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 14:44 [PATCH 0/2] io_uring: fix locking in __io_run_local_work Dylan Yudaken
2022-10-27 14:44 ` [PATCH 1/2] io_uring: use io_run_local_work_locked helper Dylan Yudaken
2022-10-27 14:44 ` [PATCH 2/2] io_uring: unlock if __io_run_local_work locked inside Dylan Yudaken
2022-10-27 15:38 ` Jens Axboe
2022-10-27 15:50 ` Dylan Yudaken
2022-10-27 15:52 ` [PATCH 0/2] io_uring: fix locking in __io_run_local_work Jens Axboe
2022-10-27 15:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox