Re: samba does not work with liburing 2.3

[Michael Tokarev <mjt@tls.msk.ru>]

08.11.2022 16:26, Stefan Metzmacher wrote:

>> http://bugs.debian.org/1023654
> 
> I don't see where this changes the struct size:

Yeah, I noticed that too after filing that bugreport,
indeed, the problem not in the size of the structures,
but in the changed way - old inline functions used the
deprecated ring_kmask & ring_kentries, while the new
ones uses new ring_mask & ring_entries.

> -       unsigned pad[4];
> +       unsigned ring_mask;
> +       unsigned ring_entries;
> +
> +       unsigned pad[2];
> 
> But I see a problem when you compile against 2.3 and run against 2.2
> as the new values are not filled.
> 
> The problem is the mixture of inline and non-inline functions...

Yeah.

> The packaging should make sure it requires the version is build against...

It is either Depends: liburing2 > $version, or, if the ABI is broken like
this, it is Depends: liburing3 > $newversion (with the soname bump).

At any rate, this is not exactly samba problem, but it affects samba.

Thanks,

/mjt