From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B24FDC433FE for ; Tue, 8 Nov 2022 13:50:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234665AbiKHNuj (ORCPT ); Tue, 8 Nov 2022 08:50:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234594AbiKHNuf (ORCPT ); Tue, 8 Nov 2022 08:50:35 -0500 X-Greylist: delayed 465 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 08 Nov 2022 05:50:29 PST Received: from isrv.corpit.ru (isrv.corpit.ru [86.62.121.231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1301BC9C for ; Tue, 8 Nov 2022 05:50:29 -0800 (PST) Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 5337B40115; Tue, 8 Nov 2022 16:42:41 +0300 (MSK) Received: from [192.168.177.130] (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 2CBE930C; Tue, 8 Nov 2022 16:42:46 +0300 (MSK) Message-ID: Date: Tue, 8 Nov 2022 16:42:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: samba does not work with liburing 2.3 Content-Language: en-US To: Stefan Metzmacher , samba-technical@lists.samba.org, io-uring References: <5a3d3b11-0858-e85f-e381-943263a92202@msgid.tls.msk.ru> <6dde692a-145f-63bd-95bd-1eb1c1b108ce@samba.org> From: Michael Tokarev In-Reply-To: <6dde692a-145f-63bd-95bd-1eb1c1b108ce@samba.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org 08.11.2022 16:26, Stefan Metzmacher wrote: >> http://bugs.debian.org/1023654 > > I don't see where this changes the struct size: Yeah, I noticed that too after filing that bugreport, indeed, the problem not in the size of the structures, but in the changed way - old inline functions used the deprecated ring_kmask & ring_kentries, while the new ones uses new ring_mask & ring_entries. > -       unsigned pad[4]; > +       unsigned ring_mask; > +       unsigned ring_entries; > + > +       unsigned pad[2]; > > But I see a problem when you compile against 2.3 and run against 2.2 > as the new values are not filled. > > The problem is the mixture of inline and non-inline functions... Yeah. > The packaging should make sure it requires the version is build against... It is either Depends: liburing2 > $version, or, if the ABI is broken like this, it is Depends: liburing3 > $newversion (with the soname bump). At any rate, this is not exactly samba problem, but it affects samba. Thanks, /mjt