From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E5A48EBEC for ; Wed, 29 Jul 2026 13:39:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785332363; cv=none; b=s12+n0G9KP7Veuzb8Ge6Hyj0dEdU0Y1q4JN5KJvkKYWiBbLHXOgO0IX27rfRKLAHrGeihjT0HSgrB4gwsDcnZNxbl8EQyvwDJmu0FbXpqPl0MXZ/PNJzyEPlGW4saqiuiML09MMTNXBZZEflK8vpGJvTQ0kxm8pEdG8qE1+FzaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785332363; c=relaxed/simple; bh=uY3sUepmqssMOr1jNQvyXWE6qqQrkaRqI5lsNd3E8OM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sNNblE2mYxkbcx8QPEoszOp+rxWn+rO7e8A79oa/7S9rm9+wp8Uj3fZC8nbWJOJorshp7HBIEdoo2p6zKaB5iA6Q9unDMjgd0MpsEZaM5azONy6pFyclzkSyA51t/sGBpzt4Zzm+27xZqc9xxGdwf66h3svgtx5VfDtNFP/WOM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KGVPcDzP; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KGVPcDzP" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-c1f5208b38dso182342466b.0 for ; Wed, 29 Jul 2026 06:39:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785332352; x=1785937152; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3aN3udKBcENjBD5UHxw3XhgPgHCGso1JhkYTFHwhTGI=; b=KGVPcDzP8wQ2SyiaYgiEB/4+DEBMYVALsc3jCB2ht0eAjAMxzC7NXELzSBNNQc9MON d+5UWFqymcPii4NKyLLs61jvxSrgM4urA7UkU2HBYDgPFjDRMUOonbQMxjRRz2fM1A1G 0KQEeIhH9kn1nef3qZipqo46Ff4aokfZS8yASW93kTavs5E/4t210s8/nqPmRCI2xWmQ cfiUS6RP81gBjK/rG275PimVCBEjZw1hM2fIi52JuSxl+y5ssYS80UyMSVQF+j+qwWAN 5FmGmrGXBoIq6mhUzjQD+AoBX6TSFQp9EuI2mNAYYE4/W/exMXsXk9Ptt68mGWbQptup dcHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785332352; x=1785937152; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3aN3udKBcENjBD5UHxw3XhgPgHCGso1JhkYTFHwhTGI=; b=OWFmQH6obr7iKLxVfcyy5zknx+3sWYoaSW2F9W6shhU5ddO9lckTIu0l2DJqM5Dczy +bJ9Q9DGyKEB1S93lFVtIIuh3izLDMtOAe9H+zwguU3TZwvKzqIM6ecSCwfQVvrern2F WPVkNgn0v1XFhvWh9KN2eP7BrwC+WSolbsdfF+aa8RjL07scpTzMcGRsJIK13ucEM09O fQ0m2xCYzzHnztBWxwGF74xfoV9+FXmyh0w+vXqL2pVuryT3Mc2FYbKX3q/mKlmeELrf Adjr8Amji8vHBhoS4Bjz67HZyOWJ/Vi+ipQ2sAyqyZMYaTtFTwuWuim0mHjLxU25w9DA ZhsQ== X-Forwarded-Encrypted: i=1; AHgh+RohprJu09SrL5HkEhtCV6KC+cAI+aYSHB1Z8vIWmRP1l6qTGtsRrvjOXuAWSMk4oI9ZLMrn0iF6Aw==@vger.kernel.org X-Gm-Message-State: AOJu0YzIL+IKUnHNCW9Vb43d8W5zx6RdHVjzpVP1HEA4ZhU55PEvGcgx s15/c/EPJUfTtbxtPwta4Z4UhjUKAvnAJ4/G4cToo8ptQM7czlVabHl8 X-Gm-Gg: AR+sD10qH9uDkqoYGVisTkNLEkt7wOhBgQL2mIr7BUQTPBLFfKc7sGE6S0ui7bv6vB6 acNb5omMDJ/pVG0uNDYz76tE7MTeZkCcoNDZRUDyf8x0dwS/izSFaHtM5DDPlWYNr7/mlYp7xjF jw0DwjLJeGpa9LF23H3payLHJhRV0ZZuePLq66JFx01z1ceBX2qTHkNrniQ4KkfTd9jSCouSMJN bk9v/RsxwCk/NBeDNY7ZWhun9aWUM8ox9WqLU9BaKpoXG00tGsz/PAa5sTOlc3x/O72GF4uDIiQ L7v10tu2GheW8BQxtJEXq2amXRQ5MWzlbTpKQvjmcL3a6ei/iqjPw+Je80evWgUPg5TTxMgUg10 emBMx3PsDjK/key7malKKCCAIuB5UM0vGCEtL5Gy4UL04AxbqPzLCogOzyr5oAe4xeOqHP6lIrs U6c0yxSi/zM8875+JC6d4Ftyg23IbKViOjz6qpAReeyoRVEeRzqdEn0pJmXQbHf2Ut8EplYnZyK CH9g9VRdrW4ICQhrZ36GLTqP/bTe0jTnaW5sjbvLH6tvpdJegaVFiNR4hEgeUYcAo2Rc3f2A8mM T1E6+DROvw89Anarl7U= X-Received: by 2002:a17:906:f598:b0:c16:7b66:4932 with SMTP id a640c23a62f3a-c1f721bf58emr374209166b.64.1785332351629; Wed, 29 Jul 2026 06:39:11 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:77fd:1068:74c8:af87? ([2620:10d:c092:600::1:640]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1f83f4de5bsm118685466b.29.2026.07.29.06.39.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 06:39:10 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 14:39:01 +0100 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 11/14] io_uring/rsrc: extend buffer update To: Anuj Gupta/Anuj Gupta , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Cc: Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Nitesh Shetty , Kanchan Joshi , Jason Gunthorpe , Damien Le Moal , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , David Sterba , Ilya Dryomov , dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org References: <633d33d8e278999f55126794fce948343403494a.1785274111.git.asml.silence@gmail.com> <73317bf9-f7df-43f9-abc2-daa25a675485@samsung.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <73317bf9-f7df-43f9-abc2-daa25a675485@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/29/26 14:31, Anuj Gupta/Anuj Gupta wrote: > On 7/29/2026 2:59 AM, Pavel Begunkov wrote: >> @@ -882,8 +894,13 @@ static struct io_rsrc_node *io_sqe_buffer_register(struct io_ring_ctx *ctx, >> struct io_imu_folio_data data; >> bool coalesced = false; >> >> - if (!uaddr) { >> - if (size) >> + if (desc->type >= __IO_REGBUF_TYPE_MAX) >> + return ERR_PTR(-EINVAL); >> + if (!mem_is_zero(&desc->__resv, sizeof(desc->__resv))) >> + return ERR_PTR(-EINVAL); > > desc->flags isn't validated here, unlike __resv. nonzero flags should > be rejected too? good catch -- Pavel Begunkov