From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>
Cc: Alexander Viro <[email protected]>,
[email protected], [email protected],
[email protected], [email protected]
Subject: [PATCH 1/2] iov: introduce ITER_BVEC_FLAG_FIXED
Date: Wed, 9 Dec 2020 02:19:51 +0000 [thread overview]
Message-ID: <de27dbca08f8005a303e5efd81612c9a5cdcf196.1607477897.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>
Add ITER_BVEC_FLAG_FIXED iov iter flag, which will allow us to reuse
passed in bvec instead of copying it. In particular it means that
iter->bvec won't be freed and page references are taken remain so
until callees don't need them, including asynchronous execution.
Signed-off-by: Pavel Begunkov <[email protected]>
---
fs/io_uring.c | 1 +
include/linux/uio.h | 14 +++++++++++---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index c536462920a3..9ff2805d0075 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2920,6 +2920,7 @@ static ssize_t io_import_fixed(struct io_kiocb *req, int rw,
}
}
+ iter->type |= ITER_BVEC_FLAG_FIXED;
return len;
}
diff --git a/include/linux/uio.h b/include/linux/uio.h
index 72d88566694e..af626eb970cf 100644
--- a/include/linux/uio.h
+++ b/include/linux/uio.h
@@ -18,6 +18,8 @@ struct kvec {
};
enum iter_type {
+ ITER_BVEC_FLAG_FIXED = 2,
+
/* iter types */
ITER_IOVEC = 4,
ITER_KVEC = 8,
@@ -29,8 +31,9 @@ enum iter_type {
struct iov_iter {
/*
* Bit 0 is the read/write bit, set if we're writing.
- * Bit 1 is the BVEC_FLAG_NO_REF bit, set if type is a bvec and
- * the caller isn't expecting to drop a page reference when done.
+ * Bit 1 is the BVEC_FLAG_FIXED bit, set if type is a bvec and the
+ * caller ensures that page references and memory baking bvec won't
+ * go away until callees finish with them.
*/
unsigned int type;
size_t iov_offset;
@@ -52,7 +55,7 @@ struct iov_iter {
static inline enum iter_type iov_iter_type(const struct iov_iter *i)
{
- return i->type & ~(READ | WRITE);
+ return i->type & ~(READ | WRITE | ITER_BVEC_FLAG_FIXED);
}
static inline bool iter_is_iovec(const struct iov_iter *i)
@@ -85,6 +88,11 @@ static inline unsigned char iov_iter_rw(const struct iov_iter *i)
return i->type & (READ | WRITE);
}
+static inline unsigned char iov_iter_bvec_fixed(const struct iov_iter *i)
+{
+ return i->type & ITER_BVEC_FLAG_FIXED;
+}
+
/*
* Total number of bytes covered by an iovec.
*
--
2.24.0
next prev parent reply other threads:[~2020-12-09 2:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 2:19 [RFC 0/2] nocopy bvec for direct IO Pavel Begunkov
2020-12-09 2:19 ` Pavel Begunkov [this message]
2020-12-09 8:36 ` [PATCH 1/2] iov: introduce ITER_BVEC_FLAG_FIXED Christoph Hellwig
2020-12-09 9:06 ` Christoph Hellwig
2020-12-09 11:54 ` Pavel Begunkov
2020-12-09 13:07 ` Al Viro
2020-12-09 13:37 ` Pavel Begunkov
2020-12-09 17:55 ` Christoph Hellwig
2020-12-09 18:24 ` Matthew Wilcox
2020-12-13 22:09 ` Pavel Begunkov
2020-12-09 2:19 ` [PATCH 2/2] block: no-copy bvec for direct IO Pavel Begunkov
2020-12-09 8:40 ` Christoph Hellwig
2020-12-09 12:01 ` Pavel Begunkov
2020-12-09 12:05 ` Christoph Hellwig
2020-12-09 12:03 ` Pavel Begunkov
2020-12-11 14:06 ` Johannes Weiner
2020-12-11 14:20 ` Pavel Begunkov
2020-12-11 15:38 ` Johannes Weiner
2020-12-11 15:47 ` Pavel Begunkov
2020-12-11 16:13 ` Johannes Weiner
2020-12-09 21:13 ` David Laight
2020-12-09 6:50 ` [RFC 0/2] nocopy " Christoph Hellwig
2020-12-09 11:54 ` Pavel Begunkov
2020-12-09 16:53 ` Jens Axboe
2020-12-13 22:03 ` Pavel Begunkov
2020-12-09 17:06 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de27dbca08f8005a303e5efd81612c9a5cdcf196.1607477897.git.asml.silence@gmail.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox