From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE6FC4338F for ; Wed, 28 Jul 2021 09:39:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17E9960F9C for ; Wed, 28 Jul 2021 09:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234989AbhG1JjJ (ORCPT ); Wed, 28 Jul 2021 05:39:09 -0400 Received: from ste-pvt-msa2.bahnhof.se ([213.80.101.71]:11690 "EHLO ste-pvt-msa2.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235659AbhG1JjF (ORCPT ); Wed, 28 Jul 2021 05:39:05 -0400 Received: from localhost (localhost [127.0.0.1]) by ste-pvt-msa2.bahnhof.se (Postfix) with ESMTP id 2F2FD3F64D; Wed, 28 Jul 2021 11:39:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at bahnhof.se Received: from ste-pvt-msa2.bahnhof.se ([127.0.0.1]) by localhost (ste-ftg-msa2.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gmxp4NXcSx4z; Wed, 28 Jul 2021 11:39:02 +0200 (CEST) Received: by ste-pvt-msa2.bahnhof.se (Postfix) with ESMTPA id 208923F623; Wed, 28 Jul 2021 11:39:01 +0200 (CEST) Received: from [192.168.0.10] (port=63846) by tnonline.net with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1m8g1k-000Auu-OJ; Wed, 28 Jul 2021 11:39:00 +0200 From: Forza Subject: Re: Stack trace with Samba VFS io_uring and large transfers To: Stefan Metzmacher , Jens Axboe , io-uring@vger.kernel.org References: <83566716-691f-ca91-295b-6d8aaafa50d2@kernel.dk> <49c893e9-8468-f326-9404-d23ed5a4b89f@tnonline.net> <74609547-b920-364b-db3b-ffb8ca7ab173@kernel.dk> <4848096b-7fc8-ba06-1238-849372d3851e@tnonline.net> <1e437b44-3917-3ea2-3231-f147b6a30ece@samba.org> Message-ID: Date: Wed, 28 Jul 2021 11:39:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1e437b44-3917-3ea2-3231-f147b6a30ece@samba.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2021-07-28 02:16, Stefan Metzmacher wrote: >> I am using Btrfs. >> >> My testing was done by exporting the share with >> >>   vfs objects = io_uring >>   vfs objects = btrfs, io_uring >> >> Same results in both cases. Exporting with "vfs objects = btrfs" (no io_uring) works as expected. > I don't think it makes a difference for the current problem, but I guess you want the following order instead: > > vfs objects = io_uring, btrfs > > metze I haven't tested that combination. However the docs mention that io_uring must be last VFS object loaded. https://www.samba.org/samba/docs/4.12/man-html/vfs_io_uring.8.html "The io_uring VFS module enables asynchronous pread, pwrite and fsync using the io_uring infrastructure of Linux (>= 5.1). This provides much less overhead compared to the usage of the pthreadpool for async io. This module SHOULD be listed last in any module stack as it requires real kernel file descriptors." The manpage for vfs_btrfs mentions that btrfs is stackable and in their example they have btrfs loaded before vfs_shadow_copy. https://www.samba.org/samba/docs/4.12/man-html/vfs_btrfs.8.html What would be the implication of having io_uring before the btrfs module? Regards Forza