From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF7C2EB5D4; Fri, 22 Aug 2025 08:15:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755850512; cv=none; b=VYLwDmxcHHAMMAuJwYnVOHizHowppV5TYukMThX998cSzT6PiihjEHQMyOiQinhFRQd5yBOzU41xNqrMrPHl169b5bNovvytCaZe/lShpsemNYs/U2gkP5vkoMEJznRR543sIJcACsmx/NJdD3ACumNtwu69bJvaenwnFkl3r5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755850512; c=relaxed/simple; bh=iW6JuuuxXN6ElMSrMPtjEUWiwHeZF5nAmyFgQWPZVJg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=B5UcPz81ifbhOni1oP9MoEl8/3DQi318CGUDvXFJFDHSD2PYQAN1Il2jPb8k7+MpHlDGQCxhKHFov1eR24S3u1PoVyfSyQm1O2KJ03SnxmdF5s3UGW7b/AJI+x/G2yHwKzReSCT0Y8LJj3BOha6BnOMfY7J/W/FUfuct99BbWl4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=XKfzn3o3; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="XKfzn3o3" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20250822081507euoutp011eb6e04748c75467354f864a5b13dcb2~eCLvKXWHt0802008020euoutp01T; Fri, 22 Aug 2025 08:15:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20250822081507euoutp011eb6e04748c75467354f864a5b13dcb2~eCLvKXWHt0802008020euoutp01T DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1755850507; bh=8D7LpAOoviBYk7WIQ6GdtJERZ5Q8as878mTjAUnE/1s=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=XKfzn3o3WVKTQX9bE3/cpVfy9yW+H778T92W7lBVbU6kRm4mXQcKAfiloG9SVAIl1 DBMfdB7LnCnsIfysL99KcFBB0FogAV6kQBHI3K43plBR35f6vTvEXBvPziUq5zs0kR Az18+L1Qjna/KGD88qj7IvZXFIdKHX7QWAyUJp50= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20250822081507eucas1p2f6977174baf330e1c895de7ac7b91cc1~eCLu2KEdp1444414444eucas1p2a; Fri, 22 Aug 2025 08:15:07 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250822081502eusmtip2e6ed6d47d5194e587353269471a8bda2~eCLqth-G50411104111eusmtip2L; Fri, 22 Aug 2025 08:15:02 +0000 (GMT) Message-ID: Date: Fri, 22 Aug 2025 10:15:01 +0200 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH RFC 22/35] dma-remap: drop nth_page() in dma_common_contiguous_remap() To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: Robin Murphy , Alexander Potapenko , Andrew Morton , Brendan Jackman , Christoph Lameter , Dennis Zhou , Dmitry Vyukov , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, iommu@lists.linux.dev, io-uring@vger.kernel.org, Jason Gunthorpe , Jens Axboe , Johannes Weiner , John Hubbard , kasan-dev@googlegroups.com, kvm@vger.kernel.org, "Liam R. Howlett" , Linus Torvalds , linux-arm-kernel@axis.com, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ide@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, Lorenzo Stoakes , Marco Elver , Michal Hocko , Mike Rapoport , Muchun Song , netdev@vger.kernel.org, Oscar Salvador , Peter Xu , Suren Baghdasaryan , Tejun Heo , virtualization@lists.linux.dev, Vlastimil Babka , wireguard@lists.zx2c4.com, x86@kernel.org, Zi Yan Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20250821200701.1329277-23-david@redhat.com> Content-Transfer-Encoding: 7bit X-CMS-MailID: 20250822081507eucas1p2f6977174baf330e1c895de7ac7b91cc1 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250821200816eucas1p1924e60579da49c1dfed300c945894d83 X-EPHeader: CA X-CMS-RootMailID: 20250821200816eucas1p1924e60579da49c1dfed300c945894d83 References: <20250821200701.1329277-1-david@redhat.com> <20250821200701.1329277-23-david@redhat.com> On 21.08.2025 22:06, David Hildenbrand wrote: > dma_common_contiguous_remap() is used to remap an "allocated contiguous > region". Within a single allocation, there is no need to use nth_page() > anymore. > > Neither the buddy, nor hugetlb, nor CMA will hand out problematic page > ranges. > > Cc: Marek Szyprowski > Cc: Robin Murphy > Signed-off-by: David Hildenbrand Acked-by: Marek Szyprowski > --- > kernel/dma/remap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c > index 9e2afad1c6152..b7c1c0c92d0c8 100644 > --- a/kernel/dma/remap.c > +++ b/kernel/dma/remap.c > @@ -49,7 +49,7 @@ void *dma_common_contiguous_remap(struct page *page, size_t size, > if (!pages) > return NULL; > for (i = 0; i < count; i++) > - pages[i] = nth_page(page, i); > + pages[i] = page++; > vaddr = vmap(pages, count, VM_DMA_COHERENT, prot); > kvfree(pages); > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland