From: Bart Van Assche <bvanassche@acm.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>, Jens Axboe <axboe@kernel.dk>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
dr.xiaosa@gmail.com,
Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Subject: Re: [PATCH liburing v1] barrier: Convert C++ barrier functions into macros
Date: Sat, 13 Sep 2025 07:40:17 -0700 [thread overview]
Message-ID: <e0559c10-104d-4da8-9f7f-d2ffd73d8df3@acm.org> (raw)
In-Reply-To: <20250913131547.466233-1-ammarfaizi2@gnuweeb.org>
On 9/13/25 6:15 AM, Ammar Faizi wrote:
> Convert them into macros just like the C version to fix it.
Converting functions into macros is a step backwards. Please check
whether removing the "static" keyword from the inline function
definitions in header files is sufficient to suppress the compiler
warning about TU-local definitions.
Thanks,
Bart.
next prev parent reply other threads:[~2025-09-13 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 13:15 [PATCH liburing v1] barrier: Convert C++ barrier functions into macros Ammar Faizi
2025-09-13 14:40 ` Bart Van Assche [this message]
2025-09-13 15:24 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0559c10-104d-4da8-9f7f-d2ffd73d8df3@acm.org \
--to=bvanassche@acm.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=axboe@kernel.dk \
--cc=dr.xiaosa@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox