From: Jens Axboe <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Dylan Yudaken <[email protected]>,
Pavel Begunkov <[email protected]>,
Facebook Kernel Team <[email protected]>,
io-uring Mailing List <[email protected]>,
Ammar Faizi <[email protected]>
Subject: Re: [PATCH liburing 0/5] multishot recvmsg docs and example
Date: Tue, 26 Jul 2022 10:49:53 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 7/26/22 10:48 AM, Ammar Faizi wrote:
> On 7/26/22 11:40 PM, Jens Axboe wrote:
>> On 7/26/22 10:32 AM, Ammar Faizi wrote:
>>> On 7/26/22 11:23 PM, Jens Axboe wrote:
>>>> [5/5] add an example for a UDP server
>>>> commit: 61d472b51e761e61cbf46caea40aaf40d8ed1484
>>>
>>> This one breaks clang-13 build, I'll send a patch.
>>
>> Hmm, built fine with clang-13/14 here?
>
> Not sure what is going on, but clang-13 on my machine is not happy:
>
> io_uring-udp.c:134:18: error: incompatible pointer types passing \
> 'struct sockaddr_in6 *' to parameter of type 'const struct sockaddr *' \
> [-Werror,-Wincompatible-pointer-types
>
> io_uring-udp.c:142:18: error: incompatible pointer types passing \
> 'struct sockaddr_in *' to parameter of type 'const struct sockaddr *' \
> [-Werror,-Wincompatible-pointer-types]
>
> Changing the compiler to GCC builds just fine. I have fixed something like
> this more than once. Strange indeed.
Regardless, the patch is sane!
--
Jens Axboe
next prev parent reply other threads:[~2022-07-26 16:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 12:14 [PATCH liburing 0/5] multishot recvmsg docs and example Dylan Yudaken
2022-07-26 12:14 ` [PATCH liburing 1/5] more consistent multishot recvmsg API parameter names Dylan Yudaken
2022-07-26 12:14 ` [PATCH liburing 2/5] order like functions together in liburing.h Dylan Yudaken
2022-07-26 12:15 ` [PATCH liburing 3/5] change io_uring_recvmsg_payload_length return type Dylan Yudaken
2022-07-26 12:15 ` [PATCH liburing 4/5] add documentation for multishot recvmsg Dylan Yudaken
2022-07-26 12:15 ` [PATCH liburing 5/5] add an example for a UDP server Dylan Yudaken
2022-07-26 16:23 ` [PATCH liburing 0/5] multishot recvmsg docs and example Jens Axboe
2022-07-26 16:32 ` Ammar Faizi
2022-07-26 16:40 ` Jens Axboe
2022-07-26 16:48 ` Ammar Faizi
2022-07-26 16:49 ` Jens Axboe [this message]
2022-07-27 7:57 ` Dylan Yudaken
2022-07-27 9:59 ` Ammar Faizi
2022-07-27 10:11 ` Ammar Faizi
2022-07-27 10:19 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox