From: Jens Axboe <[email protected]>
To: Hillf Danton <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 2/2] io-wq: eliminate the need for a manager thread
Date: Tue, 23 Mar 2021 07:57:56 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 3/23/21 3:15 AM, Hillf Danton wrote:
> On Mon, 22 Mar 2021 12:00:59 Jens Axboe wrote:
>>
>> @@ -109,19 +110,16 @@ struct io_wq {
>> free_work_fn *free_work;
>> io_wq_work_fn *do_work;
>>
>> - struct task_struct *manager;
>> -
> [...]
>> -static void io_wq_cancel_pending(struct io_wq *wq)
>
> No more caller on destroying wq?
Should probably keep that for io_wq_destroy(), I'll add it.
Thanks.
>> -{
>> - struct io_cb_cancel_data match = {
>> - .fn = io_wq_work_match_all,
>> - .cancel_all = true,
>> - };
>> - int node;
>> -
>> - for_each_node(node)
>> - io_wqe_cancel_pending_work(wq->wqes[node], &match);
>> -}
> [...]
>> static void io_wq_destroy_manager(struct io_wq *wq)
>
> s/io_wq_destroy_manager/__io_wq_destroy/ as manager is gone.
Renamed - also missed another comment on having the manager create
a worker, fixed that one up too.
--
Jens Axboe
prev parent reply other threads:[~2021-03-23 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 18:00 [PATCHSET 0/2] Eliminated need for io thread manager Jens Axboe
2021-03-22 18:00 ` [PATCH 1/2] kernel: allow fork with TIF_NOTIFY_SIGNAL pending Jens Axboe
2021-03-22 18:00 ` [PATCH 2/2] io-wq: eliminate the need for a manager thread Jens Axboe
[not found] ` <[email protected]>
2021-03-23 13:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox