public inbox for [email protected]
 help / color / mirror / Atom feed
From: Pavel Begunkov <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Subject: Re: [liburing PATCH] io_uring: invalid fd for file-less operations
Date: Thu, 14 Nov 2019 00:31:00 +0300	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <b74f30f890ef054cff370f3f8fae68fd264e1c5e.1573680315.git.asml.silence@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 370 bytes --]

On 14/11/2019 00:27, Pavel Begunkov wrote:
> If an operation doesn't need a file, set fd to an invalid value.
> This would help to spot an unwanted fdget() in the kernel, and is
> conceptually more correct (though negotiable)
> 

Either we can add a test with close(0) beforehand, but it
won't much help with new opcodes in the future. 

-- 
Pavel Begunkov


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-11-13 21:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 21:27 [liburing PATCH] io_uring: invalid fd for file-less operations Pavel Begunkov
2019-11-13 21:31 ` Pavel Begunkov [this message]
2019-11-13 21:39 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox