public inbox for [email protected]
 help / color / mirror / Atom feed
From: Bart Van Assche <[email protected]>
To: Pavel Begunkov <[email protected]>, Jens Axboe <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] io_uring: Optimize and improve the hot path
Date: Fri, 29 Jan 2021 11:10:09 -0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 1/29/21 4:46 AM, Pavel Begunkov wrote:
> It doesn't apply well, not for 5.11 nor for-5.12, and one more
> comment below

This patch was prepared on top of Linus' master branch. I will rebase it
on top of Jens' for-next branch.

>>  		req = list_first_entry(done, struct io_kiocb, inflight_entry);
>> -		if (READ_ONCE(req->result) == -EAGAIN) {
>> +		if (smp_load_acquire(&req->iopoll_completed) &&
> 
> No need, you can't get here unless exactly same iopoll_completed
> check succeeded in io_do_iopoll().

Agreed, I will revert this change. Thanks for having taken a look!

Bart.


      parent reply	other threads:[~2021-01-29 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 18:36 [PATCH] io_uring: Optimize and improve the hot path Bart Van Assche
     [not found] ` <[email protected]>
2021-01-29 19:10   ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox