public inbox for [email protected]
 help / color / mirror / Atom feed
From: Stefan Roesch <[email protected]>
To: Filipe Manana <[email protected]>
Cc: [email protected], [email protected],
	[email protected], [email protected],
	[email protected]
Subject: Re: [PATCH v2 05/12] btrfs: add btrfs_try_lock_ordered_range
Date: Thu, 8 Sep 2022 11:12:45 -0700	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAL3q7H7pRTH7YFnSmeQ1iZcp2Hr2ddkW-qBEBp31n9a50KJ-9w@mail.gmail.com>



On 9/8/22 3:18 AM, Filipe Manana wrote:
> > 
> On Thu, Sep 8, 2022 at 1:26 AM Stefan Roesch <[email protected]> wrote:
>>
>> From: Josef Bacik <[email protected]>
>>
>> For IOCB_NOWAIT we're going to want to use try lock on the extent lock,
>> and simply bail if there's an ordered extent in the range because the
>> only choice there is to wait for the ordered extent to complete.
>>
>> Signed-off-by: Josef Bacik <[email protected]>
>> Signed-off-by: Stefan Roesch <[email protected]>
>> ---
>>  fs/btrfs/ordered-data.c | 28 ++++++++++++++++++++++++++++
>>  fs/btrfs/ordered-data.h |  1 +
>>  2 files changed, 29 insertions(+)
>>
>> diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
>> index 1952ac85222c..3cdfdcedb088 100644
>> --- a/fs/btrfs/ordered-data.c
>> +++ b/fs/btrfs/ordered-data.c
>> @@ -1041,6 +1041,34 @@ void btrfs_lock_and_flush_ordered_range(struct btrfs_inode *inode, u64 start,
>>         }
>>  }
>>
>> +/*
>> + * btrfs_try_lock_ordered_range - lock the passed range and ensure all pending
>> + * ordered extents in it are run to completion in nowait mode.
>> + *
>> + * @inode:        Inode whose ordered tree is to be searched
>> + * @start:        Beginning of range to flush
>> + * @end:          Last byte of range to lock
>> + *
>> + * This function returns 1 if btrfs_lock_ordered_range does not return any
>> + * extents, otherwise 0.
> 
> Why not a bool, true/false? That's all that is needed, and it's clear.
> 
> Thanks.
>

The next version of the patch series will return bool instead of int.
 
>> + */
>> +int btrfs_try_lock_ordered_range(struct btrfs_inode *inode, u64 start, u64 end)
>> +{
>> +       struct btrfs_ordered_extent *ordered;
>> +
>> +       if (!try_lock_extent(&inode->io_tree, start, end))
>> +               return 0;
>> +
>> +       ordered = btrfs_lookup_ordered_range(inode, start, end - start + 1);
>> +       if (!ordered)
>> +               return 1;
>> +
>> +       btrfs_put_ordered_extent(ordered);
>> +       unlock_extent(&inode->io_tree, start, end);
>> +       return 0;
>> +}
>> +
>> +
>>  static int clone_ordered_extent(struct btrfs_ordered_extent *ordered, u64 pos,
>>                                 u64 len)
>>  {
>> diff --git a/fs/btrfs/ordered-data.h b/fs/btrfs/ordered-data.h
>> index 87792f85e2c4..ec27ebf0af4b 100644
>> --- a/fs/btrfs/ordered-data.h
>> +++ b/fs/btrfs/ordered-data.h
>> @@ -218,6 +218,7 @@ void btrfs_wait_ordered_roots(struct btrfs_fs_info *fs_info, u64 nr,
>>  void btrfs_lock_and_flush_ordered_range(struct btrfs_inode *inode, u64 start,
>>                                         u64 end,
>>                                         struct extent_state **cached_state);
>> +int btrfs_try_lock_ordered_range(struct btrfs_inode *inode, u64 start, u64 end);
>>  int btrfs_split_ordered_extent(struct btrfs_ordered_extent *ordered, u64 pre,
>>                                u64 post);
>>  int __init ordered_data_init(void);
>> --
>> 2.30.2
>>

  reply	other threads:[~2022-09-08 18:12 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-08  0:26 [PATCH v2 00/12] io-uring/btrfs: support async buffered writes Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 01/12] mm: export balance_dirty_pages_ratelimited_flags() Stefan Roesch
2022-09-08 10:18   ` Filipe Manana
2022-09-08  0:26 ` [PATCH v2 02/12] btrfs: implement a nowait option for tree searches Stefan Roesch
2022-09-08 13:19   ` Josef Bacik
2022-09-08 18:05     ` Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 03/12] btrfs: make can_nocow_extent nowait compatible Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 04/12] btrfs: add the ability to use NO_FLUSH for data reservations Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 05/12] btrfs: add btrfs_try_lock_ordered_range Stefan Roesch
2022-09-08 10:18   ` Filipe Manana
2022-09-08 18:12     ` Stefan Roesch [this message]
2022-09-08  0:26 ` [PATCH v2 06/12] btrfs: make btrfs_check_nocow_lock nowait compatible Stefan Roesch
2022-09-08 10:18   ` Filipe Manana
2022-09-08 18:23     ` Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 07/12] btrfs: make prepare_pages " Stefan Roesch
2022-09-08 10:17   ` Filipe Manana
2022-09-08 18:33     ` Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 08/12] btrfs: make lock_and_cleanup_extent_if_need " Stefan Roesch
2022-09-08 10:17   ` Filipe Manana
2022-09-08 18:38     ` Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 09/12] btrfs: btrfs: plumb NOWAIT through the write path Stefan Roesch
2022-09-08 10:16   ` Filipe Manana
2022-09-08 18:44     ` Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 10/12] btrfs: make balance_dirty_pages nowait compatible Stefan Roesch
2022-09-08 10:16   ` Filipe Manana
2022-09-08 18:48     ` Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 11/12] btrfs: add assert to search functions Stefan Roesch
2022-09-08 10:15   ` Filipe Manana
2022-09-08 19:10     ` Stefan Roesch
2022-09-08  0:26 ` [PATCH v2 12/12] btrfs: enable nowait async buffered writes Stefan Roesch
2022-09-08 10:14   ` Filipe Manana
2022-09-08 19:14     ` Stefan Roesch
2022-09-08 10:14 ` [PATCH v2 00/12] io-uring/btrfs: support " Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox