From: Pavel Begunkov <[email protected]>
To: [email protected]
Cc: Jens Axboe <[email protected]>, [email protected]
Subject: [PATCH liburing 5/6] test/zc: recv asynchronously
Date: Thu, 4 Aug 2022 15:20:24 +0100 [thread overview]
Message-ID: <e50ed637cdba845e7f68f7e97fb05dee69b007d4.1659622771.git.asml.silence@gmail.com> (raw)
In-Reply-To: <[email protected]>
Receive in a separate task to avoid locking up in case of short sends.
Signed-off-by: Pavel Begunkov <[email protected]>
---
test/send-zerocopy.c | 56 ++++++++++++++++++++++++++++++++------------
1 file changed, 41 insertions(+), 15 deletions(-)
diff --git a/test/send-zerocopy.c b/test/send-zerocopy.c
index d0f5931..617e7a0 100644
--- a/test/send-zerocopy.c
+++ b/test/send-zerocopy.c
@@ -653,7 +653,8 @@ static int do_test_inet_send(struct io_uring *ring, int sock_client, int sock_se
size_t chunk_size = send_size / nr_reqs;
size_t chunk_size_last = send_size - chunk_size * (nr_reqs - 1);
char *buf = buffers_iov[buf_idx].iov_base;
- size_t bytes_received = 0;
+ pid_t p;
+ int wstatus;
assert(send_size <= buffers_iov[buf_idx].iov_len);
memset(rx_buffer, 0, send_size);
@@ -700,16 +701,35 @@ static int do_test_inet_send(struct io_uring *ring, int sock_client, int sock_se
return 1;
}
- while (bytes_received != send_size) {
- ret = recv(sock_server,
- rx_buffer + bytes_received,
- send_size - bytes_received, 0);
- if (ret <= 0) {
- fprintf(stderr, "recv failed, got %i, errno %i\n",
- ret, errno);
- return 1;
+ p = fork();
+ if (p == -1) {
+ fprintf(stderr, "fork() failed\n");
+ return 1;
+ }
+
+ if (p == 0) {
+ size_t bytes_received = 0;
+
+ while (bytes_received != send_size) {
+ ret = recv(sock_server,
+ rx_buffer + bytes_received,
+ send_size - bytes_received, 0);
+ if (ret <= 0) {
+ fprintf(stderr, "recv failed, got %i, errno %i\n",
+ ret, errno);
+ exit(1);
+ }
+ bytes_received += ret;
}
- bytes_received += ret;
+
+ for (i = 0; i < send_size; i++) {
+ if (buf[i] != rx_buffer[i]) {
+ fprintf(stderr, "botched data, first mismated byte %i, "
+ "%u vs %u\n", i, buf[i], rx_buffer[i]);
+ exit(1);
+ }
+ }
+ exit(0);
}
for (i = 0; i < nr_reqs; i++) {
@@ -734,11 +754,17 @@ static int do_test_inet_send(struct io_uring *ring, int sock_client, int sock_se
io_uring_cqe_seen(ring, cqe);
}
- for (i = 0; i < send_size; i++) {
- if (buf[i] != rx_buffer[i]) {
- fprintf(stderr, "botched data, first mismated byte %i, "
- "%u vs %u\n", i, buf[i], rx_buffer[i]);
- }
+ if (waitpid(p, &wstatus, 0) == (pid_t)-1) {
+ perror("waitpid()");
+ return 1;
+ }
+ if (!WIFEXITED(wstatus)) {
+ fprintf(stderr, "child failed %i\n", WEXITSTATUS(wstatus));
+ return 1;
+ }
+ if (WEXITSTATUS(wstatus)) {
+ fprintf(stderr, "child failed\n");
+ return 1;
}
return 0;
}
--
2.37.0
next prev parent reply other threads:[~2022-08-04 14:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 14:20 [PATCH liburing 0/6] improve zeoropy testing Pavel Begunkov
2022-08-04 14:20 ` [PATCH liburing 1/6] test/zc: improve error messages Pavel Begunkov
2022-08-04 14:20 ` [PATCH liburing 2/6] tests/zc: test tcp Pavel Begunkov
2022-08-04 14:20 ` [PATCH liburing 3/6] test/zc: allocate buffers dynamically Pavel Begunkov
2022-08-04 14:20 ` [PATCH liburing 4/6] test/zc: handle short rx Pavel Begunkov
2022-08-04 14:20 ` Pavel Begunkov [this message]
2022-08-04 14:20 ` [PATCH liburing 6/6] test/zc: test short zc send Pavel Begunkov
2022-08-04 22:22 ` [PATCH liburing 0/6] improve zeoropy testing Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e50ed637cdba845e7f68f7e97fb05dee69b007d4.1659622771.git.asml.silence@gmail.com \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox