From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E65C433FE for ; Sat, 12 Dec 2020 17:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 222AA21D46 for ; Sat, 12 Dec 2020 17:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404003AbgLLRky (ORCPT ); Sat, 12 Dec 2020 12:40:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391958AbgLLRky (ORCPT ); Sat, 12 Dec 2020 12:40:54 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26D4AC0613CF for ; Sat, 12 Dec 2020 09:40:14 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id w16so9515012pga.9 for ; Sat, 12 Dec 2020 09:40:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WWML1PSJLcf6MkRp0X+stinBaJ09ip4IkyLqML27Uwo=; b=bDFO1IPjxtgw5y04lv/TvngC/Uipv6qikte6f3u7yLK92lZJWfCg/1Aze9CsUlGqpk LuvXsl5PSrG5mwUbcje+/a5OgAtcGjMmcURHCk0HC7NiglcQqq4BgaF0TWwZ2lTUKLdc yeCvnbetGY32B6LU1HlAlqfvUsquYpmvPaPUmR3EAzv1FOoDb/B82mWkrOY82UqEdk7C 81PinXu/XfonzHp2AIQSC4F2y2WRFEJvKcFXHgmVa6Z7vpdZtgStzTDqzWXfWIkeQQHg 7oGqOFk0725FTeIleryCmXr3j1For3/PyH+OthH2QNDNlI3g37fpHNhfEeNJaLMJJSxl glKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WWML1PSJLcf6MkRp0X+stinBaJ09ip4IkyLqML27Uwo=; b=PEmnbysT1SdnllRnoNFs7ojjzZ4x3CK6OED8sxk1h5Qu/8FdsJS+PRrrFt4EMtFiNG rmeY3nQuOdqvwNhUnLnhKl1L5SpTGIHRIFiUnrbFwcbQxVk5RX09FZE48pcp3v1rP/pY GvaoJcE7NGxbR3HCxqMYL1ZkJmf3qheiTTmhXiaEAzeMdwtHjdc5EcDEIuPZYT4rCeiO hguTRoni+2c4j4ruNuJ3r8WEjzq6bZSePHedcCJ2Hk5DJ/7hhD0Nw/P/tIf8SD7bT/sT +6BNElvv9hnwTMCBu5LYaiTcYFzVe3eTTYM5+Vd0UUFXVhISF74nKFvuRfzEK4guEU5R DU/A== X-Gm-Message-State: AOAM531bkwVumi4inmNR7S+iBJxlLKB9W3Qw0q2heikdixCqhfqJ4rr3 IIDv1qo+m2TgKGZ3EfYdFJSLvw== X-Google-Smtp-Source: ABdhPJx4gVsRtcLF4m5lMN3DWJ4DPIVmN7LCQ6lN3arQtljVvo6hY/5nM9ZNOGDTFjKOHkjPPMdLyw== X-Received: by 2002:a63:494f:: with SMTP id y15mr17080646pgk.364.1607794813595; Sat, 12 Dec 2020 09:40:13 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id y3sm14988472pjb.18.2020.12.12.09.40.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Dec 2020 09:40:12 -0800 (PST) Subject: Re: [PATCH 0/3] PROTO_CMSG_DATA_ONLY for Datagram (UDP) To: Victor Stewart Cc: io-uring , Soheil Hassas Yeganeh , netdev , Stefan Metzmacher , Jann Horn References: <750bc4e7-c2ce-e33d-dc98-483af96ff330@kernel.dk> From: Jens Axboe Message-ID: Date: Sat, 12 Dec 2020 10:40:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 12/12/20 10:25 AM, Victor Stewart wrote: > On Sat, Dec 12, 2020 at 5:07 PM Jens Axboe wrote: >> >> On 12/12/20 8:31 AM, Victor Stewart wrote: >>> RE our conversation on the "[RFC 0/1] whitelisting UDP GSO and GRO >>> cmsgs" thread... >>> >>> https://lore.kernel.org/io-uring/CAM1kxwi5m6i8hrtkw7nZYoziPTD-Wp03+fcsUwh3CuSc=81kUQ@mail.gmail.com/ >>> >>> here are the patches we discussed. >>> >>> Victor Stewart (3): >>> net/socket.c: add PROTO_CMSG_DATA_ONLY to __sys_sendmsg_sock >>> net/ipv4/af_inet.c: add PROTO_CMSG_DATA_ONLY to inet_dgram_ops >>> net/ipv6/af_inet6.c: add PROTO_CMSG_DATA_ONLY to inet6_dgram_ops >>> >>> net/ipv4/af_inet.c >>> | 1 + >>> net/ipv6/af_inet6.c >>> | 1 + >>> net/socket.c >>> | 8 +- >>> 3 files changed, 7 insertions(+), 3 deletions(-) >> >> Changes look fine to me, but a few comments: >> >> - I'd order 1/3 as 3/3, that ordering makes more sense as at that point it >> could actually be used. > > right that makes sense. > >> >> - For adding it to af_inet/af_inet6, you should write a better commit message >> on the reasoning for the change. Right now it just describes what the >> patch does (which is obvious from the change), not WHY it's done. Really >> goes for current 1/3 as well, commit messages need to be better in >> general. >> > > okay thanks Jens. i would have reiterated the intention but assumed it > were implicit given I linked the initial conversation about enabling > UDP_SEGMENT (GSO) and UDP_GRO through io_uring. > >> I'd also CC Jann Horn on the series, he's the one that found an issue there >> in the past and also acked the previous change on doing PROTO_CMSG_DATA_ONLY. > > I CCed him on this reply. Soheil at the end of the first exchange > thread said he audited the UDP paths and believed this to be safe. > > how/should I resubmit the patch with a proper intention explanation in > the meta and reorder the patches? my first patch and all lol. Just post is as a v2 with the change noted in the cover letter. I'd also ensure that it threads properly, right now it's just coming through as 4 separate emails at my end. If you're using git send-email, make sure you add --thread to the arguments. -- Jens Axboe