From: Jens Axboe <[email protected]>
To: Tony Solomonik <[email protected]>
Cc: [email protected], [email protected], [email protected],
[email protected]
Subject: Re: [PATCH v2 2/2] io_uring: add support for ftruncate
Date: Tue, 23 Jan 2024 08:50:06 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 1/23/24 4:33 AM, Tony Solomonik wrote:
> +int io_ftruncate_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
> +{
> + struct io_ftrunc *ft = io_kiocb_to_cmd(req, struct io_ftrunc);
> +
> + if (sqe->addr || sqe->rw_flags || sqe->buf_index || sqe->splice_fd_in)
> + return -EINVAL;
Since you're not using len anymore, that should be included in these
checks, and addr3.
--
Jens Axboe
next prev parent reply other threads:[~2024-01-23 15:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAD62OrGa9pS6-Qgg_UD4r4d+kCSPQihq0VvtVombrbAAOroG=w@mail.gmail.com>
2024-01-23 11:33 ` [PATCH v2 1/2] Add __do_ftruncate that truncates a struct file* Tony Solomonik
2024-01-23 11:33 ` [PATCH v2 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-23 15:01 ` Gabriel Krisman Bertazi
2024-01-23 15:36 ` Jens Axboe
2024-01-23 15:46 ` Jens Axboe
2024-01-23 15:50 ` Jens Axboe [this message]
2024-01-23 21:19 ` [PATCH v3 0/2] Add ftruncate to io_uring Tony Solomonik
2024-01-23 21:19 ` [PATCH v3 1/2] Add ftruncate_file that truncates a struct file* Tony Solomonik
2024-01-23 22:07 ` Jens Axboe
2024-01-23 21:19 ` [PATCH v3 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-23 22:11 ` Jens Axboe
2024-01-23 22:33 ` [PATCH v4 0/2] " Tony Solomonik
2024-01-23 22:33 ` [PATCH v4 1/2] Add ftruncate_file that truncates a struct file Tony Solomonik
2024-01-23 22:33 ` [PATCH v4 2/2] io_uring: add support for ftruncate Tony Solomonik
2024-01-23 23:24 ` [PATCH v4 0/2] " Jens Axboe
[not found] ` <CAD62OrEC62Ojh+uvMWMb7X=fNZerUVYfUWFmRHQ-49OvTJ1u4Q@mail.gmail.com>
2024-01-23 23:40 ` Jens Axboe
2024-01-23 14:53 ` [PATCH v2 1/2] Add __do_ftruncate that truncates a struct file* Gabriel Krisman Bertazi
2024-01-23 15:38 ` Jens Axboe
2024-01-23 15:40 ` Jens Axboe
[not found] <[email protected]>
2024-01-23 11:32 ` Tony Solomonik
2024-01-23 11:32 ` [PATCH v2 2/2] io_uring: add support for ftruncate Tony Solomonik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox