From: Pavel Begunkov <[email protected]>
To: Palash Oswal <[email protected]>
Cc: Dmitry Vyukov <[email protected]>, Jens Axboe <[email protected]>,
[email protected], LKML <[email protected]>,
syzkaller-bugs <[email protected]>,
[email protected]
Subject: Re: KASAN: null-ptr-deref Write in io_uring_cancel_sqpoll
Date: Tue, 27 Apr 2021 12:20:20 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAGyP=7e6xiNVEV6Bc21i0v+e9GWmm2UdTbhDzyNTmMY4Pa=_ng@mail.gmail.com>
On 4/27/21 11:39 AM, Palash Oswal wrote:
> On Tue, Apr 27, 2021 at 2:07 PM Pavel Begunkov <[email protected]> wrote:
>>
>> io_sq_offload_create() {
>> ...
>> ret = io_uring_alloc_task_context(tsk, ctx);
>> wake_up_new_task(tsk);
>> if (ret)
>> goto err;
>> }
>>
>> Shouldn't happen unless offload create has failed. Just add
>> a return in *cancel_sqpoll() for this case. It's failing
>> so no requests has been submitted and no cancellation is needed.
>
> io_uring_cancel_sqpoll can be called by two flows:
> 1. io_uring_task_cancel() -> io_sqpoll_cancel_sync() ->
> io_uring_cancel_sqpoll ; which properly sanitises current->io_uring
> to be non NULL. (
> https://elixir.bootlin.com/linux/v5.12/source/include/linux/io_uring.h#L21
> )
> 2. io_sq_offload_create -> io_sq_thread -> io_uring_cancel_sqpoll ;
> which does not check the value of current->io_uring
>
> In the second flow,
> https://elixir.bootlin.com/linux/v5.12/source/fs/io_uring.c#L7970
> The initialization of current->io_uring (i.e
> io_uring_alloc_task_context() ) happens after calling io_sq_thread.
> And, therefore io_uring_cancel_sqpoll receives a NULL value for
> current->io_uring.
Right, exactly as I wrote in the previous message. And still placing
the check in io_uring_cancel_sqpoll() is a better (safer) option.
Just send a patch for 5.13 and mark it stable
>
> The backtrace from the crash confirms the second scenario:
> [ 70.661551] ==================================================================
> [ 70.662764] BUG: KASAN: null-ptr-deref in io_uring_cancel_sqpoll+0x203/0x350
> [ 70.663834] Write of size 4 at addr 0000000000000060 by task iou-sqp-750/755
> [ 70.664025]
> [ 70.664025] CPU: 1 PID: 755 Comm: iou-sqp-750 Not tainted 5.12.0 #101
> [ 70.664025] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS 1.14.0-1 04/01/2014
> [ 70.664025] Call Trace:
> [ 70.664025] dump_stack+0xe9/0x168
> [ 70.664025] ? io_uring_cancel_sqpoll+0x203/0x350
> [ 70.664025] __kasan_report+0x166/0x1c0
> [ 70.664025] ? io_uring_cancel_sqpoll+0x203/0x350
> [ 70.664025] kasan_report+0x4f/0x70
> [ 70.664025] kasan_check_range+0x2f3/0x340
> [ 70.664025] __kasan_check_write+0x14/0x20
> [ 70.664025] io_uring_cancel_sqpoll+0x203/0x350
> [ 70.664025] ? io_sq_thread_unpark+0xd0/0xd0
> [ 70.664025] ? mutex_lock+0xbb/0x130
> [ 70.664025] ? init_wait_entry+0xe0/0xe0
> [ 70.664025] ? wait_for_completion_killable_timeout+0x20/0x20
> [ 70.664025] io_sq_thread+0x174c/0x18c0
> [ 70.664025] ? io_rsrc_put_work+0x380/0x380
> [ 70.664025] ? init_wait_entry+0xe0/0xe0
> [ 70.664025] ? _raw_spin_lock_irq+0xa5/0x180
> [ 70.664025] ? _raw_spin_lock_irqsave+0x190/0x190
> [ 70.664025] ? calculate_sigpending+0x6b/0xa0
> [ 70.664025] ? io_rsrc_put_work+0x380/0x380
> [ 70.664025] ret_from_fork+0x22/0x30
>
> We might want to add additional validation before calling
> io_uring_cancel_sqpoll. I did verify that the reproducer stopped
> producing the bug after the following change.
> ---
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index dff34975d86b..36fc9abe8022 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6832,8 +6832,10 @@ static int io_sq_thread(void *data)
> timeout = jiffies + sqd->sq_thread_idle;
> }
>
> - list_for_each_entry(ctx, &sqd->ctx_list, sqd_list)
> - io_uring_cancel_sqpoll(ctx);
> + list_for_each_entry(ctx, &sqd->ctx_list, sqd_list) {
> + if (current->io_uring)
> + io_uring_cancel_sqpoll(ctx);
> + }
> sqd->thread = NULL;
> list_for_each_entry(ctx, &sqd->ctx_list, sqd_list)
> io_ring_set_wakeup_flag(ctx);
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-04-27 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 9:33 KASAN: null-ptr-deref Write in io_uring_cancel_sqpoll syzbot
[not found] ` <[email protected]>
2021-04-27 6:29 ` Dmitry Vyukov
2021-04-27 7:05 ` Palash Oswal
2021-04-27 8:37 ` Pavel Begunkov
2021-04-27 10:39 ` Palash Oswal
2021-04-27 11:20 ` Pavel Begunkov [this message]
2021-04-27 12:51 ` [PATCH 5.13] io_uring: Check current->io_uring " Palash Oswal
2021-04-27 13:08 ` Pavel Begunkov
2021-04-27 13:37 ` Jens Axboe
2021-04-27 17:00 ` Pavel Begunkov
2021-04-27 17:00 ` Jens Axboe
2021-04-27 17:04 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox