From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>,
Victor Stewart <[email protected]>
Cc: io-uring <[email protected]>
Subject: Re: [BUG? liburing] io_uring_register_files_update with liburing 2.0 on 5.13.17
Date: Sun, 19 Sep 2021 08:24:12 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 9/19/21 5:56 AM, Pavel Begunkov wrote:
> On 9/18/21 11:21 PM, Jens Axboe wrote:
>> On 9/18/21 3:55 PM, Victor Stewart wrote:
>>>> BTW, this could be incorporated into io_uring_register_files and
>>>> io_uring_register_files_tags(), might not be a bad idea in general. Just
>>>> have it check rlim.rlim_cur for RLIMIT_NOFILE, and if it's smaller than
>>>> 'nr_files', then bump it. That'd hide it nicely, instead of throwing a
>>>> failure.
>>>
>>> the implicit bump sounds like a good idea (at least in theory?).
>>
>> Can you try current liburing -git? Remove your own RLIMIT_NOFILE and
>> just verify that it works. I pushed a change for it.
>
> Sounds like it pretty easy can be a very unexpected behaviour. Do many
> libraries / etc. implicitly tinker with it?
Don't know if they do, but as long as we simply increase probably not a
huge problem, even if not the prettiest. I just wish we had done this
for the 2.1 release, to avoid people running into this for stable
backports. At least it's a fairly well known (and specific) error code
for this case.
--
Jens Axboe
prev parent reply other threads:[~2021-09-19 14:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 13:41 [BUG? liburing] io_uring_register_files_update with liburing 2.0 on 5.13.17 Victor Stewart
2021-09-18 14:41 ` Jens Axboe
2021-09-18 20:13 ` Victor Stewart
2021-09-18 20:26 ` Jens Axboe
2021-09-18 20:38 ` Jens Axboe
2021-09-18 21:55 ` Victor Stewart
2021-09-18 22:21 ` Jens Axboe
2021-09-18 23:19 ` Victor Stewart
2021-09-18 23:23 ` Victor Stewart
2021-09-18 23:37 ` Jens Axboe
2021-09-18 23:40 ` Jens Axboe
2021-09-19 4:15 ` Vito Caputo
2021-09-19 14:16 ` Jens Axboe
2021-09-20 12:51 ` Victor Stewart
2021-09-20 13:10 ` Jens Axboe
2021-09-20 13:19 ` Victor Stewart
2021-09-19 11:56 ` Pavel Begunkov
2021-09-19 14:24 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox