From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39681DA5F for ; Sat, 1 Mar 2025 02:19:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740795581; cv=none; b=NdeGb4sXMbB8i8zH9aormkgH/y/vJ8Z+5xE8hBd63zX297GPKmvryNNf6KNAij79fN2HlG1oieqh5Yh850LfvUUsUHuwYNa7WllXPnkun1bGb5nFsSJkYByzzOpEv721X73f3gk/Ly8izxOy8iStY8T9VB9kKagKhgiWlWWrBtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740795581; c=relaxed/simple; bh=kZsMvfWa8qntmAFeFfLmWLX+D9k6qyIykJXEp/W/2Og=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ICnZHGocRmVG3cKUtxAlltabf65S8T1sVJcv2xSaNSndCIzNOb7hFQHb0CDBQwNIna1zGgZAT3SM0BTUgyTFD9abphQZITnLeIAOhZ+53DZXbA8Xh7xP+UZkqqk/8iH95tJZrt4AHAXgniccOZccvsO5m/0/AUNb5ve9rIPyJcg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=UZOfXT39; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="UZOfXT39" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-6fb2a0e4125so17870687b3.1 for ; Fri, 28 Feb 2025 18:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1740795579; x=1741400379; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z4XZtAvaxTkTRVYPnyP6lhU6SQoTpqrSM17+f7p2/eo=; b=UZOfXT39WtWlmOmA5mnK/QbOFcxwXUDddSuG7qYexz89BtjYwDIT1nTtgMfiB83ESR /bQx+Gn9xFye75gSX+d9BYRViKs3Ai5Wg4MlPCvQSMxXo/uRlO1FcyCvh+4hhVPDR8vX Xns3W/0nbOneBINXQsHxEm7lUdTu0ijsUFJErWt6yBNVQxSkO1NQ9DmnNchUNeYT4L8j XoLfipTsZlDDx2qZU2Ffp/aSM6MYIGTLBJ5HE7XUTWPHGgeUSdZuvKvLlNKduJPHptkX olYp4r6C/jUd9bm9vG78PgFZtPXV0JebL3R8zSW1UDtw07kPPwXi+0G6ChmTQEdhqiCM D8wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740795579; x=1741400379; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z4XZtAvaxTkTRVYPnyP6lhU6SQoTpqrSM17+f7p2/eo=; b=DPYBHb1gt8X/PqoJSVUF2p5xIEZ5bV62hqZgttROtM/JLh3pJS2ppo/WFptEWBGjmy J4ercsYJYQ0EG4Ng3xjuYpXP841mJ23QcRJwxJcNOfCPuQMo+xvD6qwkFXNl5UbNsh9J tKyqk8SU9ZkFchyde+YENsA9dJcqQOIGzgKSZ/icfJ8fIhKs1y60Jd8+Iq1q7Rh91IPI N1gh6CDtCUe3PffDEkpqyYRcwiSbGMlTHlzN5rTgETaDQMSBt1+sadEJzK3xUrei7Z48 8f8LIywPkokDF6gohNuyRmb7BIhKYegYcTssoppV5tRbzoSX7mmP0PEao5oi/dSPkUdv 4tlg== X-Forwarded-Encrypted: i=1; AJvYcCWvoq6xl3GvCGjpadgk2rOWsYrsD/krsGZeo9FaPb/lhIu5HI+KCnKKYTrN6seBxQAX7LAERQrfSw==@vger.kernel.org X-Gm-Message-State: AOJu0YxX2PgwSjJ5D/EkpmCVSis/mVLG5yvXuKC9aNc6hxTxcsOLA0Gc x4u10IiF+jb/FnhwmP6aHHFnXzPdNxBEVzrF6OyJGpcto9PwbcgSJUmWD9k5LYg= X-Gm-Gg: ASbGncsjET++Q6Sevgx68SFC/gCcT/BbCD7zYu4mdnD+tT0xvMEXu23ilwd6btKOXYZ /g/WeQGPxUTeJb3Io9Eqt3v6og4MXTYACNoZHaEfpLOx7eOFpdW3RomVTMagy2sKB6DA6LFrQNh 0C2oOxLEvmHlgHkJdyXnNCKaATiJS019v/eA/4EqK3S/jyOWMSTKSSXE0TKgXeW8EHzLKGFzk3l tBujAL7Xl/6IhBMSGpxJ3crkjaQCRh73SDxtvO4wE7k1PnTbnTJhr8keFNyBZ0kskeKHvPMXnbW eCKCpPq6o/Su3seGK5RFXDZ8gHfeapHfCz3umD5i1Zdr X-Google-Smtp-Source: AGHT+IHPbXyxz8wWnLiMHMh7DD3CmUXpngJlQ2P3Z57O3VfMgGqTT4+HJ3NwT8O/Y50+KLmi6i4NCg== X-Received: by 2002:a05:690c:490e:b0:6f9:9e80:46bf with SMTP id 00721157ae682-6fd4a14d099mr74054517b3.29.1740795578759; Fri, 28 Feb 2025 18:19:38 -0800 (PST) Received: from [192.168.21.25] ([207.222.175.10]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6fd3ca443adsm9980187b3.36.2025.02.28.18.19.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2025 18:19:38 -0800 (PST) Message-ID: Date: Fri, 28 Feb 2025 19:19:37 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 0/3] selftests: add ublk selftests To: Ming Lei Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, Keith Busch , io-uring@vger.kernel.org References: <20250228161919.2869102-1-ming.lei@redhat.com> <360708f8-437f-4262-a734-b1bd680de339@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/28/25 6:11 PM, Ming Lei wrote: > On Fri, Feb 28, 2025 at 09:37:47AM -0700, Jens Axboe wrote: >> On 2/28/25 9:19 AM, Ming Lei wrote: >>> Hello Jens, >>> >>> This patchset adds ublk kernel selftests, which is very handy for >>> developer for verifying kernel change, especially ublk heavily depends >>> on io_uring subsystem. Also it provides template for target implementation. >>> >>> Please consider it for v6.15. >> >> Can we add the zc bits to the liburing test case as well? > > OK, will unify the two tests and cover liburing too. > > BTW, would you like to consider to move liburing tests or part of them > into kernel selftests? > > This way looks more friendly for kernel developer: > > - single repo, and single patchset can include both io_uring kernel > patches and selftests change > > - easy to run test against same kernel repo I have considered it, but at least the way I run the liburing tests, it uses a bunch of different types of devices to get full coverage. It's not really a fire-off-and-forget kind of setup. Yes you can run it like that and not have it use any other fs or device, but you won't get full coverage. The liburing regression tests are also meant to be run on ANY kernel, not just the current kernel. Eg I do that for stable kernels. As far as I can tell, the only win here would be that it'd be easier for someone to run when making a kernel change. And that is a nice win indeed. But there are so many downsides for me and the tests in general, that I don't see that win as being nearly big enough to warrant switching it over. For new feature tests, I think adding that as kernel selftests may make more sense - test that it works, test failure/error cases, etc. > Also liburing development may be decoupled from io_uring kernel > a bit. It's already entirely decoupled from the kernel. At least as much as it can be. Yes the uapi header is shared and synced across them, but there's really no other dependency there and no version dependencies between liburing and the kernel. -- Jens Axboe