Re: [PATCH v4 1/6] io_uring/mock: add basic infra for test mock files

[Pavel Begunkov <asml.silence@gmail.com>]

On 5/30/25 15:09, Pavel Begunkov wrote:
> On 5/30/25 14:28, Jens Axboe wrote:
>> On 5/30/25 6:51 AM, Pavel Begunkov wrote:
>>> diff --git a/init/Kconfig b/init/Kconfig
>>> index 63f5974b9fa6..9e8a5b810804 100644
>>> --- a/init/Kconfig
>>> +++ b/init/Kconfig
>>> @@ -1774,6 +1774,17 @@ config GCOV_PROFILE_URING
>>>         the io_uring subsystem, hence this should only be enabled for
>>>         specific test purposes.
>>> +config IO_URING_MOCK_FILE
>>> +    tristate "Enable io_uring mock files (Experimental)" if EXPERT
>>> +    default n
>>> +    depends on IO_URING && KASAN
>>> +    help
>>> +      Enable mock files for io_uring subststem testing. The ABI might
>>> +      still change, so it's still experimental and should only be enabled
>>> +      for specific test purposes.
>>> +
>>> +      If unsure, say N.
>>
>> As mentioned in the other email, I don't think we should include KASAN
>> here.
> 
> I disagree. It's supposed to give a superset of coverage, if not,
> mocking should be improved. It might be seen as a nuisance that you
> can't run it with a stock kernel, but that desire is already half
> step from "let's enable it for prod kernels for testing", and then
> distributions will start forcing it on, because as you said "People
> do all sorts of weird stuff".

The purpose is to get the project even more hardened / secure through
elaborate testing, that would defeat the purpose if non test systems
will start getting errors because of some mess up, let's say in the
driver.

-- 
Pavel Begunkov