Re: [PATCH] io-wq: remove unused label

[Jens Axboe <axboe@kernel.dk>]

On 2/24/21 7:18 PM, Chaitanya Kulkarni wrote:
> Remove unused label so that we can get rid of the following warning:-
> 
> fs/io-wq.c: In function ‘io_get_next_work’:
> fs/io-wq.c:357:1: warning: label ‘restart’ defined but not used
> [-Wunused-label]
>  restart:
> 
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> 
> Without this patch :-
> # makej fs/
>   DESCEND  objtool
>   CALL    scripts/atomic/check-atomics.sh
>   CALL    scripts/checksyscalls.sh
>   CC      fs/io-wq.o
> fs/io-wq.c: In function ‘io_get_next_work’:
> fs/io-wq.c:357:1: warning: label ‘restart’ defined but not used [-Wunused-label]
>  restart:
>  ^~~~~~~
>   AR      fs/built-in.a
> 
> With this patch :-
> 
> linux-block (for-next) # git am 0001-io-wq-remove-unused-label.patch
> Applying: io-wq: remove unused label
> linux-block (for-next) # makej fs/
>   DESCEND  objtool
>   CALL    scripts/atomic/check-atomics.sh
>   CALL    scripts/checksyscalls.sh
>   CC      fs/io-wq.o
>   AR      fs/built-in.a
> 
> ---
>  fs/io-wq.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/io-wq.c b/fs/io-wq.c
> index 42ce01183b51..169e1d6a7ee2 100644
> --- a/fs/io-wq.c
> +++ b/fs/io-wq.c
> @@ -354,7 +354,6 @@ static struct io_wq_work *io_get_next_work(struct io_wqe *wqe)
>  	struct io_wq_work *work, *tail;
>  	unsigned int stall_hash = -1U;
>  
> -restart:
>  	wq_list_for_each(node, prev, &wqe->work_list) {
>  		unsigned int hash;
>  

This was dropped from for-next for now anyway, as it needed to handle
more cases.

-- 
Jens Axboe