* [PATCH] io-wq: remove unused label
@ 2021-02-25 2:18 Chaitanya Kulkarni
2021-02-25 15:18 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Chaitanya Kulkarni @ 2021-02-25 2:18 UTC (permalink / raw)
To: axboe, asml.silence; +Cc: io-uring, Chaitanya Kulkarni
Remove unused label so that we can get rid of the following warning:-
fs/io-wq.c: In function ‘io_get_next_work’:
fs/io-wq.c:357:1: warning: label ‘restart’ defined but not used
[-Wunused-label]
restart:
Signed-off-by: Chaitanya Kulkarni <[email protected]>
---
Without this patch :-
# makej fs/
DESCEND objtool
CALL scripts/atomic/check-atomics.sh
CALL scripts/checksyscalls.sh
CC fs/io-wq.o
fs/io-wq.c: In function ‘io_get_next_work’:
fs/io-wq.c:357:1: warning: label ‘restart’ defined but not used [-Wunused-label]
restart:
^~~~~~~
AR fs/built-in.a
With this patch :-
linux-block (for-next) # git am 0001-io-wq-remove-unused-label.patch
Applying: io-wq: remove unused label
linux-block (for-next) # makej fs/
DESCEND objtool
CALL scripts/atomic/check-atomics.sh
CALL scripts/checksyscalls.sh
CC fs/io-wq.o
AR fs/built-in.a
---
fs/io-wq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/io-wq.c b/fs/io-wq.c
index 42ce01183b51..169e1d6a7ee2 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -354,7 +354,6 @@ static struct io_wq_work *io_get_next_work(struct io_wqe *wqe)
struct io_wq_work *work, *tail;
unsigned int stall_hash = -1U;
-restart:
wq_list_for_each(node, prev, &wqe->work_list) {
unsigned int hash;
--
2.22.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io-wq: remove unused label
2021-02-25 2:18 [PATCH] io-wq: remove unused label Chaitanya Kulkarni
@ 2021-02-25 15:18 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-02-25 15:18 UTC (permalink / raw)
To: Chaitanya Kulkarni, asml.silence; +Cc: io-uring
On 2/24/21 7:18 PM, Chaitanya Kulkarni wrote:
> Remove unused label so that we can get rid of the following warning:-
>
> fs/io-wq.c: In function ‘io_get_next_work’:
> fs/io-wq.c:357:1: warning: label ‘restart’ defined but not used
> [-Wunused-label]
> restart:
>
> Signed-off-by: Chaitanya Kulkarni <[email protected]>
> ---
>
> Without this patch :-
> # makej fs/
> DESCEND objtool
> CALL scripts/atomic/check-atomics.sh
> CALL scripts/checksyscalls.sh
> CC fs/io-wq.o
> fs/io-wq.c: In function ‘io_get_next_work’:
> fs/io-wq.c:357:1: warning: label ‘restart’ defined but not used [-Wunused-label]
> restart:
> ^~~~~~~
> AR fs/built-in.a
>
> With this patch :-
>
> linux-block (for-next) # git am 0001-io-wq-remove-unused-label.patch
> Applying: io-wq: remove unused label
> linux-block (for-next) # makej fs/
> DESCEND objtool
> CALL scripts/atomic/check-atomics.sh
> CALL scripts/checksyscalls.sh
> CC fs/io-wq.o
> AR fs/built-in.a
>
> ---
> fs/io-wq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/io-wq.c b/fs/io-wq.c
> index 42ce01183b51..169e1d6a7ee2 100644
> --- a/fs/io-wq.c
> +++ b/fs/io-wq.c
> @@ -354,7 +354,6 @@ static struct io_wq_work *io_get_next_work(struct io_wqe *wqe)
> struct io_wq_work *work, *tail;
> unsigned int stall_hash = -1U;
>
> -restart:
> wq_list_for_each(node, prev, &wqe->work_list) {
> unsigned int hash;
>
This was dropped from for-next for now anyway, as it needed to handle
more cases.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-25 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-25 2:18 [PATCH] io-wq: remove unused label Chaitanya Kulkarni
2021-02-25 15:18 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox