From: Olivier Langlois <[email protected]>
To: Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>,
[email protected]
Subject: Re: [PATCH] io_uring/napi: remove duplicate io_napi_entry timeout assignation
Date: Tue, 13 Aug 2024 13:22:38 -0400 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On Mon, 2024-08-12 at 14:40 -0600, Jens Axboe wrote:
>
>
> > 3. I am surprised to notice that in __io_napi_do_busy_loop(),
> > list_for_each_entry_rcu() is called to traverse the list but the
> > regular methods list_del() and list_add_tail() are called to update
> > the
> > list instead of their RCU variant.
>
> Should all just use rcu variants.
>
> Here's a mashup of the changes. Would be great if you can test - I'll
> do
> some too, but always good with more than one person testing as it
> tends
> to hit more cases.
>
Jens,
I have integrated our RCU corrections into
https://lore.kernel.org/io-uring/5fc9dd07e48a7178f547ed1b2aaa0814607fa246.1723567469.git.olivier@trillion01.com/T/#u
and my testing so far is not showing any problems...
but I have a very static setup...
I had no issues too without the corrections...
next prev parent reply other threads:[~2024-08-13 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 0:34 [PATCH] io_uring/napi: remove duplicate io_napi_entry timeout assignation Olivier Langlois
2024-08-12 1:00 ` Olivier Langlois
2024-08-12 18:10 ` Jens Axboe
2024-08-12 18:11 ` Jens Axboe
2024-08-12 20:15 ` Olivier Langlois
2024-08-12 20:40 ` Jens Axboe
2024-08-12 21:39 ` Olivier Langlois
2024-08-12 21:45 ` Olivier Langlois
2024-08-12 21:50 ` Jens Axboe
2024-08-13 17:22 ` Olivier Langlois [this message]
2024-08-13 18:35 ` Jens Axboe
2024-08-14 0:09 ` Olivier Langlois
2024-08-14 0:31 ` Jens Axboe
2024-08-14 0:44 ` Pavel Begunkov
2024-08-12 18:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7e8a80ffcca7b3527b74be5741c927937517291.camel@trillion01.com \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox