Re: [PATCH V5 0/2] io_uring: uring_cmd: add multishot support with provided buffer

[Jens Axboe <axboe@kernel.dk>]

On 8/21/25 5:41 AM, Jens Axboe wrote:
> 
> On Thu, 21 Aug 2025 12:02:05 +0800, Ming Lei wrote:
>> This patchset adds multishot support with provided buffer, see details in
>> commit log of patch 2.
>>
>> Thanks,
>> Ming
>>
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/2] io-uring: move `struct io_br_sel` into io_uring_types.h
>       commit: 1a8ceff033519eac7bb5ab1d910e9b0340835c0d
> [2/2] io_uring: uring_cmd: add multishot support
>       commit: 55dc643dd2ad15e755a706980692a374de1bb7a8

I did notice an issue with !CONFIG_IO_URING, but figured I could just
fix it up as it should not need a respin for that. Below is the
incremental I applied while committing this.


diff --git a/include/linux/io_uring/cmd.h b/include/linux/io_uring/cmd.h
index 856d343b8e2a..be0e29b72669 100644
--- a/include/linux/io_uring/cmd.h
+++ b/include/linux/io_uring/cmd.h
@@ -117,12 +117,11 @@ static inline void io_uring_cmd_mark_cancelable(struct io_uring_cmd *cmd,
 static inline void io_uring_cmd_issue_blocking(struct io_uring_cmd *ioucmd)
 {
 }
-static inline int io_uring_cmd_select_buffer(struct io_uring_cmd *ioucmd,
-				unsigned buf_group,
-				void **buf, size_t *len,
-				unsigned int issue_flags)
+static inline struct io_br_sel
+io_uring_cmd_buffer_select(struct io_uring_cmd *ioucmd, unsigned buf_group,
+			   size_t *len, unsigned int issue_flags);
 {
-	return -EOPNOTSUPP;
+	return (struct io_br_sel) { .val = -EOPNOTSUPP };
 }
 static inline bool io_uring_mshot_cmd_post_cqe(struct io_uring_cmd *ioucmd,
 				ssize_t ret, unsigned int issue_flags)


-- 
Jens Axboe