From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0E84C47096 for ; Thu, 3 Jun 2021 12:54:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 922D5613DE for ; Thu, 3 Jun 2021 12:54:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230114AbhFCMzo (ORCPT ); Thu, 3 Jun 2021 08:55:44 -0400 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:38584 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229950AbhFCMzo (ORCPT ); Thu, 3 Jun 2021 08:55:44 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R601e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=haoxu@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0Ub9lXwA_1622724837; Received: from B-25KNML85-0107.local(mailfrom:haoxu@linux.alibaba.com fp:SMTPD_---0Ub9lXwA_1622724837) by smtp.aliyun-inc.com(127.0.0.1); Thu, 03 Jun 2021 20:53:58 +0800 To: Jens Axboe , Pavel Begunkov Cc: io-uring From: Hao Xu Subject: Question about poll_multi_file Message-ID: Date: Thu, 3 Jun 2021 20:53:57 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org Hi Jens, I've a question about poll_multi_file in io_do_iopoll(). It keeps spinning in f_op->iopoll() if poll_multi_file is true (and we're under the requested amount). But in my understanding, reqs may be in different hardware queues for blk-mq device even in this situation. Should we consider the hardware queue number as well? Some thing like below: diff --git a/fs/io_uring.c b/fs/io_uring.c index 7b0e6bc9ea3d..479a75022449 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -2533,10 +2533,13 @@ static void io_iopoll_req_issued(struct io_kiocb *req, bool in_async) ctx->poll_multi_file = false; } else if (!ctx->poll_multi_file) { struct io_kiocb *list_req; + unsigned int queue_num0, queue_num1; list_req = list_first_entry(&ctx->iopoll_list, struct io_kiocb, inflight_entry); - if (list_req->file != req->file) + queue_num0 = blk_qc_t_to_queue_num(list_req->rw.kiocb.ki_cookie); + queue_num1 = blk_qc_t_to_queue_num(req->rw.kiocb.ki_cookie); + if (list_req->file != req->file || queue_num0 != queue_num1) ctx->poll_multi_file = true; }