* [PATCH 1/1] io_uring/zcrx: use READ_ONCE with user shared RQEs
@ 2026-03-04 12:37 Pavel Begunkov
2026-03-04 13:30 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Begunkov @ 2026-03-04 12:37 UTC (permalink / raw)
To: io-uring; +Cc: asml.silence, axboe, netdev
Refill queue entries are shared with the user space, use READ_ONCE when
reading them.
Fixes: 34a3e60821ab9 ("io_uring/zcrx: implement zerocopy receive pp memory provider");
Cc: stable@vger.kernel.org
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
io_uring/zcrx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
index 19b287d21f4b..0461edebb042 100644
--- a/io_uring/zcrx.c
+++ b/io_uring/zcrx.c
@@ -927,11 +927,12 @@ static inline bool io_parse_rqe(struct io_uring_zcrx_rqe *rqe,
struct io_zcrx_ifq *ifq,
struct net_iov **ret_niov)
{
+ __u64 off = READ_ONCE(rqe->off);
unsigned niov_idx, area_idx;
struct io_zcrx_area *area;
- area_idx = rqe->off >> IORING_ZCRX_AREA_SHIFT;
- niov_idx = (rqe->off & ~IORING_ZCRX_AREA_MASK) >> ifq->niov_shift;
+ area_idx = off >> IORING_ZCRX_AREA_SHIFT;
+ niov_idx = (off & ~IORING_ZCRX_AREA_MASK) >> ifq->niov_shift;
if (unlikely(rqe->__pad || area_idx))
return false;
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] io_uring/zcrx: use READ_ONCE with user shared RQEs
2026-03-04 12:37 [PATCH 1/1] io_uring/zcrx: use READ_ONCE with user shared RQEs Pavel Begunkov
@ 2026-03-04 13:30 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2026-03-04 13:30 UTC (permalink / raw)
To: io-uring, Pavel Begunkov; +Cc: netdev
On Wed, 04 Mar 2026 12:37:43 +0000, Pavel Begunkov wrote:
> Refill queue entries are shared with the user space, use READ_ONCE when
> reading them.
>
>
Applied, thanks!
[1/1] io_uring/zcrx: use READ_ONCE with user shared RQEs
commit: 531bb98a030cc1073bd7ed9a502c0a3a781e92ee
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-04 13:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-04 12:37 [PATCH 1/1] io_uring/zcrx: use READ_ONCE with user shared RQEs Pavel Begunkov
2026-03-04 13:30 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox