From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B7C8F49 for ; Wed, 4 Mar 2026 12:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772627874; cv=none; b=bvTCLcrdalbsa2fRkm37ImgFJ6GaoiGEaVv2T1DPKDqPjcF5TX91wnoHCa6AlsWhk44xK7w/2Az75p2msu03qKcQ1o1pGXYALDMo9laYxxk4ZxCVb0bYw8uAapi3FYOW6mAb4oC5Clx6J/qNDWMnJUPuPOYLRQjp1hXdS2JvbfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772627874; c=relaxed/simple; bh=zJuo7qMutHORFwQoVNSSuIoEfHsEUlmjBsGv1qbTk3s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RxdyCYl3M7Q/oTtyTGq4xQuaJH6tdnIG6ttDRkHcvKxKtRpSXTKz5PCAVbIUcHUMuD0M9w1TAv5FpRhMy5iTHYLNd0UL9sRtS8QujvEKbzNWlzQV/DHdXnJ49ssQamTKVIHpA8YeP0hgRVVyFr7LBv2jHaY3oIpMUqkzg796/jU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RzHi1LdL; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RzHi1LdL" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-483a233819aso66918435e9.3 for ; Wed, 04 Mar 2026 04:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772627872; x=1773232672; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=UxB/uFtMk7BfQyoh1WMZKIcALFnrrxe/IZwZ8/zch24=; b=RzHi1LdLnHZhTUDlkDjWx705yW7nMp5SCcE6YFZo+lgpo2RoVx4FnG2xpfN97NIp0A svpyAyC3+EssTHbgM04HQYwgtEwtssaRDmTBgUUunNPVmCRcP3XaucIMEgUe9e0XAnVP 0J9oDvky1YRAlXKA+P9i4v998vZjUZyq12a+/hHFu2xG7Uw14CQQzNhyJc1EMWZUZbPI Q+LTMdc9lRJ/dHTASXqDcf3oQERjxCZmfR9RUS3gk13NVVuf2bz7PwgXIrIfu2Qie9D7 vyV1+2762D+SLCno+tpjiRJaflZWyVKaHi/HxgjXZw+Zc/chwm30YvEN2yfNiegi3J8O aI1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772627872; x=1773232672; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UxB/uFtMk7BfQyoh1WMZKIcALFnrrxe/IZwZ8/zch24=; b=LpV+bOgZcDAHpDPkLiEYmnNkRvpSOcbIv6/HtomnxF+LHMTUiENR47TT3Ir5rWZ0rY EZ+W/twYeeR1zyTOPkuW2IgYo54LmYDPcQA0cyFC/amr8c0d5+VXnsPjm2A+dp56ogWh x6Fung3+Y2fq5SGNAgzCdExckRwOA18fq9xKLkp7Jc2hbElxVaVE6hmqigi706oBx5zr EVThjKO5Swb86wGLprvtBWQfPKK/Pe3kHJxSyvfz6VKztlk2LwOiONhxa6RTE2RosmzG U+cq7k88MeZ8oVVc9eFaeg7vGxX+/v2hNt8QneWRREza+fMEfClcMx9RhXI+fT/VVyDW QmJw== X-Gm-Message-State: AOJu0YwT4sehqF8/Fxw83D3c2FGA+ikUxHYQjzIWmaWiF2gd2yh9twc8 sy4I602g9genbDVD1pdr++7HLpLEfcPFXSAvePgEJQww/gPHBreTDAHD8MzUPQ== X-Gm-Gg: ATEYQzzfDT7tTU2JNXPgxLTNCjG4+AJsBgKJcvI0xy4Yf4tP0DNlrNGrVTHh16mBSk9 TdheIzTyluFmJOsxPoo/0B81yg8u2d9jdrRukc5umAac89thxXakmBcMV1rPm09vNwhhPuH+MQz 9w2oru0TGCMm+H3I0knJT0gA+9r7KgX7d17eVUi/ilZsgl7bOjJZHHd20xlGVrEMFRH1DXSFFTt FOBisAhXjfAbw6c3CWcXDyhbD222rclA5Cidy06cnZ9sG08bczv8UCfrDeYSJ5TXSgVbPCBmLXS JLREOJBLpM7AU89pqlaldx1QtgI8jkEHj1t7RcFXemKJ7EEqroGdTi9WmpaMwR9CEN1y+jqeI/a XIQHQHVxWTKR7Clzea0btMFleI7Pi/1JXkSLRFLG5ew7P21d0ud4yrLErRW60GTQP1hq3kVa+7C zi0OhRz6jVcepQffMxMnzQ9UU8v5yHQCmP6HxOpp/u4V1BTj1KAM0ygG8i3JdGlMcHrlsBw6Tp9 sh4/96eklfXfy4apjxOKkexOIpF2A== X-Received: by 2002:a05:600c:8105:b0:477:7bca:8b34 with SMTP id 5b1f17b1804b1-4851983bf08mr28109745e9.6.1772627871679; Wed, 04 Mar 2026 04:37:51 -0800 (PST) Received: from 127.mynet ([2a01:4b00:bd21:4f00:7cc6:d3ca:494:116c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851a7fef84sm26505775e9.1.2026.03.04.04.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Mar 2026 04:37:51 -0800 (PST) From: Pavel Begunkov To: io-uring@vger.kernel.org Cc: asml.silence@gmail.com, axboe@kernel.dk, netdev@vger.kernel.org Subject: [PATCH 1/1] io_uring/zcrx: use READ_ONCE with user shared RQEs Date: Wed, 4 Mar 2026 12:37:43 +0000 Message-ID: X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Refill queue entries are shared with the user space, use READ_ONCE when reading them. Fixes: 34a3e60821ab9 ("io_uring/zcrx: implement zerocopy receive pp memory provider"); Cc: stable@vger.kernel.org Signed-off-by: Pavel Begunkov --- io_uring/zcrx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c index 19b287d21f4b..0461edebb042 100644 --- a/io_uring/zcrx.c +++ b/io_uring/zcrx.c @@ -927,11 +927,12 @@ static inline bool io_parse_rqe(struct io_uring_zcrx_rqe *rqe, struct io_zcrx_ifq *ifq, struct net_iov **ret_niov) { + __u64 off = READ_ONCE(rqe->off); unsigned niov_idx, area_idx; struct io_zcrx_area *area; - area_idx = rqe->off >> IORING_ZCRX_AREA_SHIFT; - niov_idx = (rqe->off & ~IORING_ZCRX_AREA_MASK) >> ifq->niov_shift; + area_idx = off >> IORING_ZCRX_AREA_SHIFT; + niov_idx = (off & ~IORING_ZCRX_AREA_MASK) >> ifq->niov_shift; if (unlikely(rqe->__pad || area_idx)) return false; -- 2.53.0