From: Jens Axboe <[email protected]>
To: Xiaoguang Wang <[email protected]>,
[email protected]
Cc: [email protected]
Subject: Re: [PATCH for-next] io_uring: initialize fixed_file_data lock
Date: Tue, 7 Apr 2020 08:46:15 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/7/20 5:02 AM, Xiaoguang Wang wrote:
> syzbot reports below warning:
> INFO: trying to register non-static key.
> the code is fine but needs lockdep annotation.
> turning off the locking correctness validator.
> CPU: 1 PID: 7099 Comm: syz-executor897 Not tainted 5.6.0-next-20200406-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Call Trace:
> __dump_stack lib/dump_stack.c:77 [inline]
> dump_stack+0x188/0x20d lib/dump_stack.c:118
> assign_lock_key kernel/locking/lockdep.c:913 [inline]
> register_lock_class+0x1664/0x1760 kernel/locking/lockdep.c:1225
> __lock_acquire+0x104/0x4e00 kernel/locking/lockdep.c:4223
> lock_acquire+0x1f2/0x8f0 kernel/locking/lockdep.c:4923
> __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
> _raw_spin_lock_irqsave+0x8c/0xbf kernel/locking/spinlock.c:159
> io_sqe_files_register fs/io_uring.c:6599 [inline]
> __io_uring_register+0x1fe8/0x2f00 fs/io_uring.c:8001
> __do_sys_io_uring_register fs/io_uring.c:8081 [inline]
> __se_sys_io_uring_register fs/io_uring.c:8063 [inline]
> __x64_sys_io_uring_register+0x192/0x560 fs/io_uring.c:8063
> do_syscall_64+0xf6/0x7d0 arch/x86/entry/common.c:295
> entry_SYSCALL_64_after_hwframe+0x49/0xb3
> RIP: 0033:0x440289
> Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7
> 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff
> ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
> RSP: 002b:00007ffff1bbf558 EFLAGS: 00000246 ORIG_RAX: 00000000000001ab
> RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440289
> RDX: 0000000020000280 RSI: 0000000000000002 RDI: 0000000000000003
> RBP: 00000000006ca018 R08: 0000000000000000 R09: 00000000004002c8
> R10: 0000000000000001 R11: 0000000000000246 R12: 0000000000401b10
> R13: 0000000000401ba0 R14: 0000000000000000 R15: 0000000000000000
>
> Initialize struct fixed_file_data's lock to fix this issue.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-04-07 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 12:02 [PATCH for-next] io_uring: initialize fixed_file_data lock Xiaoguang Wang
2020-04-07 15:46 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox