From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [PATCH 1/3] io_uring: propagate req cache creation errors
Date: Fri, 31 Jan 2025 09:26:04 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <8adc7ffcac05a8f1ae2c309ea1d0806b5b0c48b4.1738339723.git.asml.silence@gmail.com>
On 1/31/25 9:24 AM, Pavel Begunkov wrote:
> It's very unlikely, but in theory cache creation can fail during
> initcall, so don't forget to return errors back if something goes wrong.
This is why SLAB_PANIC is used, it'll panic if this fails. That's
commonly used for setup/init time kind of setups, where we never
expect any failure to occur. Hence this can never return NULL.
--
Jens Axboe
next prev parent reply other threads:[~2025-01-31 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 16:24 [PATCH 0/3] check errors in early init Pavel Begunkov
2025-01-31 16:24 ` [PATCH 1/3] io_uring: propagate req cache creation errors Pavel Begunkov
2025-01-31 16:26 ` Jens Axboe [this message]
2025-01-31 16:30 ` Pavel Begunkov
2025-01-31 16:24 ` [PATCH 2/3] io_uring: propagate io_buffer " Pavel Begunkov
2025-01-31 16:24 ` [PATCH 3/3] io_uring: check for iowq alloc_workqueue errors Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox