public inbox for [email protected]
 help / color / mirror / Atom feed
From: Hao Xu <[email protected]>
To: Jens Axboe <[email protected]>, [email protected]
Cc: Pavel Begunkov <[email protected]>
Subject: Re: [PATCH] io_uring: net: fix bug of completing multishot accept twice
Date: Fri, 17 Jun 2022 22:34:00 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 6/17/22 22:23, Jens Axboe wrote:
> On 6/17/22 8:12 AM, Hao Xu wrote:
>> From: Hao Xu <[email protected]>
>>
>> Now that we use centralized completion in io_issue_sqe, we should skip
>> that for multishot accept requests since we complete them in the
>> specific op function.
>>
>> Fixes: 34106529422e ("io_uring: never defer-complete multi-apoll")
>> Signed-off-by: Hao Xu <[email protected]>
>> ---
>>
>> I retrieved the history:
>>
>> in 4e86a2c98013 ("io_uring: implement multishot mode for accept")
>> we add the multishot accept, it repeatly completes cqe in io_accept()
>> until get -EAGAIN [1], then it returns 0 to io_issue_sqe().
>> io_issue_sqe() does nothing to it then.
>>
>> in 09eaa49e078c ("io_uring: handle completions in the core")
>> we add __io_req_complete() for IOU_OK in io_issue_sqe(). This causes at
>> [1], we do call __io_req_complete().But since IO_URING_F_COMPLETE_DEFER
>> is set, it does nothing.
>>
>> in 34106529422e ("io_uring: never defer-complete multi-apoll")
>> we remove IO_URING_F_COMPLETE_DEFER, but unluckily the multishot accept
>> test is broken, we didn't find the error.
>>
>> So it just has infuence to for-5.20, I'll update the liburing test
>> today.
> 
> Do you mind if I fold this into:
> 
> 09eaa49e078c ("io_uring: handle completions in the core")
> 
> as I'm continually rebasing the 5.20 branch until 5.19 is fully sorted?
> 

Please do, that is better.


  reply	other threads:[~2022-06-17 14:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 14:12 [PATCH] io_uring: net: fix bug of completing multishot accept twice Hao Xu
2022-06-17 14:23 ` Jens Axboe
2022-06-17 14:34   ` Hao Xu [this message]
2022-06-17 14:34     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox