From: David Wei <dw@davidwei.uk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH liburing 1/3] examples: remove zcrx size limiting
Date: Mon, 21 Apr 2025 10:38:27 -0700 [thread overview]
Message-ID: <eb4d1e04-b330-45e7-870b-fa254632519d@davidwei.uk> (raw)
In-Reply-To: <a5ad67ad-f5ca-49fd-9bcc-53277394fac1@gmail.com>
On 2025-04-20 23:40, Pavel Begunkov wrote:
> On 4/21/25 01:22, David Wei wrote:
>> On 2025-04-20 04:24, Pavel Begunkov wrote:
>>> It's not handled too well and is not great at show casing the feature,
>>> remove it for now, we may add it back later in a different form.
>>>
>>> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
>>> ---
>>> examples/zcrx.c | 34 ++++------------------------------
>>> 1 file changed, 4 insertions(+), 30 deletions(-)
>>>
>>
>> I'm relying on this selftest. Can the deletion wait until the
>> replacement is ready?
>
> I assumed you're using the selftest, and not this liburing/examples/*
>
> Anyway, let's see what I can do with it
>
Oh my mistake :facepalm: I got this mixed up with the selfteset.
next prev parent reply other threads:[~2025-04-21 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-20 11:24 [PATCH liburing 0/3] zcrx refill queue allocation modes Pavel Begunkov
2025-04-20 11:24 ` [PATCH liburing 1/3] examples: remove zcrx size limiting Pavel Begunkov
2025-04-21 0:22 ` David Wei
2025-04-21 6:40 ` Pavel Begunkov
2025-04-21 17:38 ` David Wei [this message]
2025-04-20 11:24 ` [PATCH liburing 2/3] examples/zcrx: constants for request types Pavel Begunkov
2025-04-21 0:25 ` David Wei
2025-04-20 11:24 ` [PATCH liburing 3/3] examples/zcrx: add refill queue allocation modes Pavel Begunkov
2025-04-21 0:28 ` David Wei
2025-04-21 6:38 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb4d1e04-b330-45e7-870b-fa254632519d@davidwei.uk \
--to=dw@davidwei.uk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox