From: Ammar Faizi <[email protected]>
To: Dylan Yudaken <[email protected]>
Cc: Facebook Kernel Team <[email protected]>,
io-uring Mailing List <[email protected]>,
Jens Axboe <[email protected]>,
Pavel Begunkov <[email protected]>
Subject: Re: [PATCH liburing v2] test that unregister_files processes task work
Date: Tue, 8 Nov 2022 17:03:15 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 11/8/22 4:53 PM, Dylan Yudaken wrote:
> + ret = io_uring_register_files(&ring, &fds[0], 2);
> +
> + sqe = io_uring_get_sqe(&ring);
> + io_uring_prep_read(sqe, 0, &buff, 1, 0);
> + sqe->flags |= IOSQE_FIXED_FILE;
> + ret = io_uring_submit(&ring);
> + if (ret != 1) {
> + fprintf(stderr, "bad submit\n");
> + return 1;
> + }
This assignment is meaningless:
ret = io_uring_register_files().
It's overwritten by ret = io_uring_submit() anyway. I suppose we
should have an error handler right after register_files().
--
Ammar Faizi
next prev parent reply other threads:[~2022-11-08 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 9:53 [PATCH liburing v2] test that unregister_files processes task work Dylan Yudaken
2022-11-08 10:03 ` Ammar Faizi [this message]
2022-11-08 10:23 ` Dylan Yudaken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox