public inbox for [email protected]
 help / color / mirror / Atom feed
From: Hao Xu <[email protected]>
To: Jens Axboe <[email protected]>, io-uring <[email protected]>
Cc: Pavel Begunkov <[email protected]>
Subject: Re: Possible bug for ring-mapped provided buffer
Date: Thu, 9 Jun 2022 18:14:55 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 6/9/22 18:06, Jens Axboe wrote:
> On 6/9/22 1:53 AM, Hao Xu wrote:
>> Hi all,
>> I haven't done tests to demonstrate it. It is for partial io case, we
>> don't consume/release the buffer before arm_poll in ring-mapped mode.
>> But seems we should? Otherwise ring head isn't moved and other requests
>> may take that buffer. What do I miss?
> 
> On vacation this week, so can't take a look at the code. But the
> principle is precisely not to consume the buffer if we arm poll, because
> then the next one can grab it instead. We don't want to consume a buffer
> over poll, as that defeats the purpose of a provided buffer. It should
> be grabbed and consumed only if we can use it right now.
> 
> Hence the way it should work is that we DON'T consume the buffer in this
> case, and that someone else can just use it. At the same time, we should
> ensure that we grab a NEW buffer for this case, whenever the poll

If we grab a new buffer for it, then we have to copy the data since we
have done partial io...this also defeats the purpose of this feature.
What the legacy provided buffer mode do in this case is just
keep/consume that buffer. So I'd think we should keep the consistency.
But yes, there may be a better way.

> triggers and we can retry the IO. As mentioned I can't check the code
> right now, but perhaps you can take a look.
> 


  reply	other threads:[~2022-06-09 10:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  7:53 Possible bug for ring-mapped provided buffer Hao Xu
2022-06-09  9:33 ` Hao Xu
2022-06-09  9:54   ` Hao Xu
2022-06-09 10:06 ` Jens Axboe
2022-06-09 10:14   ` Hao Xu [this message]
2022-06-09 10:19     ` Jens Axboe
2022-06-09 10:32       ` Hao Xu
2022-06-09 15:06         ` Jens Axboe
2022-06-09 16:08           ` Hao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox