public inbox for [email protected]
 help / color / mirror / Atom feed
From: Hao Xu <[email protected]>
To: Jens Axboe <[email protected]>
Cc: [email protected], Pavel Begunkov <[email protected]>,
	Joseph Qi <[email protected]>
Subject: Re: [PATCH liburing] io-cancel: add check for -ECANCELED
Date: Fri, 29 Oct 2021 20:27:23 +0800	[thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

ping this one since test/io-cancel will be broken
if the async hybrid logic merges to 5.16
在 2021/10/19 下午5:23, Hao Xu 写道:
> The req to be async cancelled will most likely return -ECANCELED after
> cancellation with the new async bybrid optimization applied. And -EINTR
> is impossible to be returned anymore since we won't be in INTERRUPTABLE
> sleep when reading, so remove it.
> 
> Signed-off-by: Hao Xu <[email protected]>
> ---
>   test/io-cancel.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/io-cancel.c b/test/io-cancel.c
> index b5b443dc467b..c761e126be0c 100644
> --- a/test/io-cancel.c
> +++ b/test/io-cancel.c
> @@ -341,7 +341,7 @@ static int test_cancel_req_across_fork(void)
>   				fprintf(stderr, "wait_cqe=%d\n", ret);
>   				return 1;
>   			}
> -			if ((cqe->user_data == 1 && cqe->res != -EINTR) ||
> +			if ((cqe->user_data == 1 && cqe->res != -ECANCELED) ||
>   			    (cqe->user_data == 2 && cqe->res != -EALREADY && cqe->res)) {
>   				fprintf(stderr, "%i %i\n", (int)cqe->user_data, cqe->res);
>   				exit(1);
> 


  reply	other threads:[~2021-10-29 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  9:23 [PATCH liburing] io-cancel: add check for -ECANCELED Hao Xu
2021-10-29 12:27 ` Hao Xu [this message]
2021-10-29 13:57   ` Pavel Begunkov
2021-10-29 15:40     ` Hao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed9793a5-92e8-f5d9-3a33-d263bf5e760e@linux.alibaba.com \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox