* [PATCH] io_uring: allow direct descriptors for connect
@ 2022-04-12 20:27 Jens Axboe
2022-04-12 20:38 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Jens Axboe @ 2022-04-12 20:27 UTC (permalink / raw)
To: io-uring
Looks like an oversight that this is currently disabled, but I guess it
didn't matter before we had direct descriptor support for socket.
Signed-off-by: Jens Axboe <[email protected]>
---
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 17b4dc9f130f..b83134906a3a 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -5982,8 +5982,7 @@ static int io_connect_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
if (unlikely(req->ctx->flags & IORING_SETUP_IOPOLL))
return -EINVAL;
- if (sqe->ioprio || sqe->len || sqe->buf_index || sqe->rw_flags ||
- sqe->splice_fd_in)
+ if (sqe->ioprio || sqe->len || sqe->buf_index || sqe->rw_flags)
return -EINVAL;
conn->addr = u64_to_user_ptr(READ_ONCE(sqe->addr));
--
Jens Axboe
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] io_uring: allow direct descriptors for connect
2022-04-12 20:27 [PATCH] io_uring: allow direct descriptors for connect Jens Axboe
@ 2022-04-12 20:38 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-04-12 20:38 UTC (permalink / raw)
To: io-uring
On 4/12/22 2:27 PM, Jens Axboe wrote:
> Looks like an oversight that this is currently disabled, but I guess it
> didn't matter before we had direct descriptor support for socket.
Disregard, obviously a bug in my test program!
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-12 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-12 20:27 [PATCH] io_uring: allow direct descriptors for connect Jens Axboe
2022-04-12 20:38 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox