From: Jens Axboe <[email protected]>
To: John David Anglin <[email protected]>,
linux-parisc <[email protected]>
Cc: [email protected], Helge Deller <[email protected]>
Subject: Re: liburing test results on hppa
Date: Thu, 16 Feb 2023 19:33:37 -0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 2/16/23 4:32 PM, Jens Axboe wrote:
> On 2/16/23 4:26?PM, John David Anglin wrote:
>> On 2023-02-16 6:12 p.m., Jens Axboe wrote:
>>> On 2/16/23 4:00?PM, John David Anglin wrote:
>>>> Running test buf-ring.t bad run 0/0 = -233
>>>> test_running(1) failed
>>>> Test buf-ring.t failed with ret 1
>>> As mentioned previously, this one and the other -233 I suspect are due
>>> to the same coloring issue as was fixed by Helge's patch for the ring
>>> mmaps, as the provided buffer rings work kinda the same way. The
>>> application allocates some aligned memory, and registers it and the
>>> kernel then maps it.
>>>
>>> I wonder if these would work properly if the address was aligned to
>>> 0x400000? Should be easy to verify, just modify the alignment for the
>>> posix_memalign() calls in test/buf-ring.c.
>> Doesn't help. Same error. Can you point to where the kernel maps it?
>
> Yep, it goes io_uring.c:io_uring_register() ->
> kbuf.c:io_register_pbuf_ring() -> rsrc.c:io_pin_pages() which ultimately
> calls pin_user_pages() to map the memory.
Followup - a few of the provided buffer ring cases failed to properly
initialize the ring, poll-mshot-race was one of them... I've pushed out
fixes for this. Not sure if it fixes your particular issue, but worth
giving it another run.
--
Jens Axboe
next prev parent reply other threads:[~2023-02-17 2:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 23:00 liburing test results on hppa John David Anglin
2023-02-16 23:12 ` Jens Axboe
2023-02-16 23:26 ` John David Anglin
2023-02-16 23:32 ` Jens Axboe
2023-02-17 2:33 ` Jens Axboe [this message]
2023-02-17 2:59 ` John David Anglin
2023-02-21 19:55 ` John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox