From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E20EC61DA4 for ; Fri, 17 Feb 2023 02:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbjBQCdm (ORCPT ); Thu, 16 Feb 2023 21:33:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbjBQCdl (ORCPT ); Thu, 16 Feb 2023 21:33:41 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 605C44B528 for ; Thu, 16 Feb 2023 18:33:39 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id 14so64739pjo.1 for ; Thu, 16 Feb 2023 18:33:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2w8YMSYWS8hZi18cPk31vQWM9RKlPae3QIDiPU465KY=; b=3UIY1NuDEUXtdfbwlB1IpM5m0BNa/pUm26bub/F+igVtmLE61RJjVDlhVNCym3wZvA WcrHAgySxFVphrq8cPVV0C6ipX9GYJen5fnwJw2KBKYHpOZi3hBedOP0TZm9FYWJcEHl WzTcmH0jYYiMJDUGUVJ3FG554Fdk/+r93FmwihANqb+d8X/KcgqRUV78MZRNaZi6tY5x itfOUT0P1Kskz8C/2jnkvkUb30wMAoOu3XU81a861OkdDOtW9oEKF/heT1J4SPz2Uup/ BLgXTXQqCJCCHQz6ZBtqzCkfId9bmvlVEwaum9ngrhic5pndKQN/dfIAcR6ouYLlkGh0 tnKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2w8YMSYWS8hZi18cPk31vQWM9RKlPae3QIDiPU465KY=; b=f56N2UcbmP4JUC/+7Bfv3U/+iz26I1k8AkSwjgCGi9+J0ibUREpvDikT2RzN59TqWj CaTq5+GTXiNhqb7nTBVIXlhdlp+F1hcuUXGZ9+Z3SSW19MBEV2hQhrCdlGriF+VOti8F wMcK5vK/cVZVxWy73GLHoY1dF8XkWyMRzXZC5UsYM/yY9pfJYg9tGdW59oxgI+4/oXD+ HziUJjuifw1wQseN+kCcm5ourww8V+AjxcD9aUn6mOuljYwF/YsWgydMDk1M1B0MU3WU CNFtwNlveetwGnQqgSAYjTVimg56Iu6igEusiLx81udI5q9YnkIfG8R5ItpTwjRrjRDe USpA== X-Gm-Message-State: AO0yUKW/fW3H4a312ZIHj3L1YKpLNDZnfgbkjs9/TWLBvY3InSFXBTQn St9wSgfiKHShrBoLIok/ZB6CQg== X-Google-Smtp-Source: AK7set/mTOm6WfGQbqbCG1/aSK6S+gGKO6r51cfA0acykNW5uOZBQlmdADx82nyqVs+G25vgU+C9LA== X-Received: by 2002:a17:902:d4c3:b0:19c:13d2:44c5 with SMTP id o3-20020a170902d4c300b0019c13d244c5mr825231plg.3.1676601218789; Thu, 16 Feb 2023 18:33:38 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id u12-20020a17090282cc00b0019a7385079esm1950965plz.123.2023.02.16.18.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 18:33:38 -0800 (PST) Message-ID: Date: Thu, 16 Feb 2023 19:33:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: liburing test results on hppa Content-Language: en-US From: Jens Axboe To: John David Anglin , linux-parisc Cc: io-uring@vger.kernel.org, Helge Deller References: <64ff4872-cc6f-1e6a-46e5-573c7e64e4c9@bell.net> <6eddaf2b-991f-f848-4832-7005eccdeffa@kernel.dk> In-Reply-To: <6eddaf2b-991f-f848-4832-7005eccdeffa@kernel.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 2/16/23 4:32 PM, Jens Axboe wrote: > On 2/16/23 4:26?PM, John David Anglin wrote: >> On 2023-02-16 6:12 p.m., Jens Axboe wrote: >>> On 2/16/23 4:00?PM, John David Anglin wrote: >>>> Running test buf-ring.t bad run 0/0 = -233 >>>> test_running(1) failed >>>> Test buf-ring.t failed with ret 1 >>> As mentioned previously, this one and the other -233 I suspect are due >>> to the same coloring issue as was fixed by Helge's patch for the ring >>> mmaps, as the provided buffer rings work kinda the same way. The >>> application allocates some aligned memory, and registers it and the >>> kernel then maps it. >>> >>> I wonder if these would work properly if the address was aligned to >>> 0x400000? Should be easy to verify, just modify the alignment for the >>> posix_memalign() calls in test/buf-ring.c. >> Doesn't help. Same error. Can you point to where the kernel maps it? > > Yep, it goes io_uring.c:io_uring_register() -> > kbuf.c:io_register_pbuf_ring() -> rsrc.c:io_pin_pages() which ultimately > calls pin_user_pages() to map the memory. Followup - a few of the provided buffer ring cases failed to properly initialize the ring, poll-mshot-race was one of them... I've pushed out fixes for this. Not sure if it fixes your particular issue, but worth giving it another run. -- Jens Axboe