[PATCH 1/1] io_uring: rearrange opdef flags by use pattern

[PATCH 1/1] io_uring: rearrange opdef flags by use pattern

[Pavel Begunkov]

Keep all flags that we use in the generic req init path close together.
That saves a load for x86 because apparently some compilers prefer
reading single bytes.

Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
---
 io_uring/opdef.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/io_uring/opdef.h b/io_uring/opdef.h
index 14456436ff74..719a52104abe 100644
--- a/io_uring/opdef.h
+++ b/io_uring/opdef.h
@@ -7,6 +7,12 @@ struct io_issue_def {
 	unsigned		needs_file : 1;
 	/* should block plug */
 	unsigned		plug : 1;
+	/* supports ioprio */
+	unsigned		ioprio : 1;
+	/* supports iopoll */
+	unsigned		iopoll : 1;
+	/* op supports buffer selection */
+	unsigned		buffer_select : 1;
 	/* hash wq insertion if file is a regular file */
 	unsigned		hash_reg_file : 1;
 	/* unbound wq insertion if file is a non-regular file */
@@ -15,14 +21,8 @@ struct io_issue_def {
 	unsigned		pollin : 1;
 	unsigned		pollout : 1;
 	unsigned		poll_exclusive : 1;
-	/* op supports buffer selection */
-	unsigned		buffer_select : 1;
 	/* skip auditing */
 	unsigned		audit_skip : 1;
-	/* supports ioprio */
-	unsigned		ioprio : 1;
-	/* supports iopoll */
-	unsigned		iopoll : 1;
 	/* have to be put into the iopoll list */
 	unsigned		iopoll_queue : 1;
 	/* vectored opcode, set if 1) vectored, and 2) handler needs to know */
-- 
2.48.1

Re: [PATCH 1/1] io_uring: rearrange opdef flags by use pattern

[Jens Axboe]

On Wed, 26 Feb 2025 20:46:34 +0000, Pavel Begunkov wrote:
> Keep all flags that we use in the generic req init path close together.
> That saves a load for x86 because apparently some compilers prefer
> reading single bytes.
> 
> 

Applied, thanks!

[1/1] io_uring: rearrange opdef flags by use pattern
      commit: 047fa0ba8f1bed6b1c5d88e31c4fd187de16dbc1

Best regards,
-- 
Jens Axboe