From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC8EC433F5 for ; Fri, 29 Oct 2021 18:00:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0DA9610A0 for ; Fri, 29 Oct 2021 18:00:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbhJ2SCl (ORCPT ); Fri, 29 Oct 2021 14:02:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbhJ2SCl (ORCPT ); Fri, 29 Oct 2021 14:02:41 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A738C061570; Fri, 29 Oct 2021 11:00:12 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id r8so4781767wra.7; Fri, 29 Oct 2021 11:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:references:in-reply-to:content-transfer-encoding; bh=HWQR8fYTD02XcaEuLM8NTcMQGMAH/ql3lEPsXCCfZPw=; b=pIcfzUPXiFHPe5KNGoRNOLFmeM0si+ZDLAoIXi//kUEy510L1lkrJgE2MXKcOjiP29 gDCJJiG2d56PpfMJq34mauY15hyIFv5qTkqwQ2hI9kS/HVeAspn9YKm2W6c70H+r9tVd A+YIs4oSuBrBYvEeDbaZlGrxmOupdsEIvflVVcXtamVJNrqTNMMHKvnxxtQ6kzTfb1ch MOc/EFWYa0rLU6/t3x4H5fX2scDCxYC+6uc7w+hMSWzGaVmW0uOPqc4XsE+uKE/0CSOS Xv0Bc3T0Fwu8voT8b0zIoMtUPAqdmZY65yyFh0cUtNYTx4OuylNIgwnOIoMVFVebfjEk xl8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=HWQR8fYTD02XcaEuLM8NTcMQGMAH/ql3lEPsXCCfZPw=; b=MMKqR6U5ZPPoXMTq1lLawZX6IHTtidh3WigpWULjeV9XufgyOYf2bKeJTijnc/7ZtA y+PDDF0Ij7rvOcmNpvJdOBdA5OtZOrM/02wKoBLDGztk0LPIBWm5irzXAEfQIzfUeOUx RD0AwItfNioQauBUoUIz0IdEnq0TK5xtPZy4CcjVJuKZgOPZ3nnyJ40E93DO6xkgZlrR ks1ND3KBDuS++L6+tU/kTgbS1o1QFs9FLk6tBUvJInUCYDuW+6eREUNCGeppaMnnX9c8 cHXVGBA1SWvyuKKPqKLGI8M1NtRs9EMvNKT6w+kkSGG2eCwQ0yq7lZOqHoM/N2d1YDfY g6Qg== X-Gm-Message-State: AOAM532h3oaY0a3TQ5bplUV/VFSbSjUym+D+dIfPsEmDTyT5R405bGEu H+ngPwWGjkQ1Yhmi30XhJ9ZYjBE7xAg= X-Google-Smtp-Source: ABdhPJygDyyz1rGmCiESGg4AxALsR2VxMBdCNlgKy9h80XGjVQiH1UMVej71NrPOPNyNiqfUZ6Kjyw== X-Received: by 2002:a1c:7f0c:: with SMTP id a12mr13146455wmd.14.1635530410718; Fri, 29 Oct 2021 11:00:10 -0700 (PDT) Received: from [192.168.8.198] ([148.252.129.16]) by smtp.gmail.com with ESMTPSA id l9sm17669wms.16.2021.10.29.11.00.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Oct 2021 11:00:10 -0700 (PDT) Message-ID: Date: Fri, 29 Oct 2021 18:59:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [syzbot] KASAN: use-after-free Write in __io_free_req Content-Language: en-US From: Pavel Begunkov To: syzbot , axboe@kernel.dk, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <000000000000fba7bd05cf7eb8f5@google.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On 10/29/21 15:45, Pavel Begunkov wrote: > On 10/29/21 15:34, syzbot wrote: >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit:    bdcc9f6a5682 Add linux-next specific files for 20211029 >> git tree:       linux-next >> console output: https://syzkaller.appspot.com/x/log.txt?x=12a87e22b00000 >> kernel config:  https://syzkaller.appspot.com/x/.config?x=cea91ee10b0cd274 >> dashboard link: https://syzkaller.appspot.com/bug?extid=78b76ebc91042904f34e >> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 >> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=10cf03e2b00000 >> >> IMPORTANT: if you fix the issue, please add the following tag to the commit: >> Reported-by: syzbot+78b76ebc91042904f34e@syzkaller.appspotmail.com > > #syz test: git://git.kernel.dk/linux-block for-5.16/io_uring #syz test: git://git.kernel.dk/linux-block 3ecd20a9c77c632a5afe4e134781e1629936adab >> ================================================================== >> BUG: KASAN: use-after-free in wq_list_add_head fs/io-wq.h:71 [inline] >> BUG: KASAN: use-after-free in __io_free_req+0x33f/0x3c5 fs/io_uring.c:2040 >> Write of size 8 at addr ffff8880713ecbb8 by task syz-executor.0/8059 >> >> CPU: 1 PID: 8059 Comm: syz-executor.0 Not tainted 5.15.0-rc7-next-20211029-syzkaller #0 >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 >> Call Trace: >>   >>   __dump_stack lib/dump_stack.c:88 [inline] >>   dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106 >>   print_address_description.constprop.0.cold+0x8d/0x320 mm/kasan/report.c:247 >>   __kasan_report mm/kasan/report.c:433 [inline] >>   kasan_report.cold+0x83/0xdf mm/kasan/report.c:450 >>   wq_list_add_head fs/io-wq.h:71 [inline] >>   __io_free_req+0x33f/0x3c5 fs/io_uring.c:2040 >>   tctx_task_work+0x1b3/0x630 fs/io_uring.c:2207 >>   task_work_run+0xdd/0x1a0 kernel/task_work.c:164 >>   exit_task_work include/linux/task_work.h:32 [inline] >>   do_exit+0xc14/0x2b40 kernel/exit.c:832 >>   do_group_exit+0x125/0x310 kernel/exit.c:929 >>   get_signal+0x47d/0x21d0 kernel/signal.c:2820 >>   arch_do_signal_or_restart+0x2a9/0x1c40 arch/x86/kernel/signal.c:868 >>   handle_signal_work kernel/entry/common.c:148 [inline] >>   exit_to_user_mode_loop kernel/entry/common.c:172 [inline] >>   exit_to_user_mode_prepare+0x17d/0x290 kernel/entry/common.c:207 >>   __syscall_exit_to_user_mode_work kernel/entry/common.c:289 [inline] >>   syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:300 >>   do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86 >>   entry_SYSCALL_64_after_hwframe+0x44/0xae >> RIP: 0033:0x7f9da8c4ea39 >> Code: Unable to access opcode bytes at RIP 0x7f9da8c4ea0f. >> RSP: 002b:00007f9da83a3218 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca >> RAX: fffffffffffffe00 RBX: 00007f9da8d62028 RCX: 00007f9da8c4ea39 >> RDX: 0000000000000000 RSI: 0000000000000080 RDI: 00007f9da8d62028 >> RBP: 00007f9da8d62020 R08: 0000000000000000 R09: 0000000000000000 >> R10: 0000000000000000 R11: 0000000000000246 R12: 00007f9da8d6202c >> R13: 00007ffd6e91741f R14: 00007f9da83a3300 R15: 0000000000022000 >>   >> >> Allocated by task 8059: >>   kasan_save_stack+0x1e/0x50 mm/kasan/common.c:38 >>   kasan_set_track mm/kasan/common.c:46 [inline] >>   set_alloc_info mm/kasan/common.c:434 [inline] >>   __kasan_slab_alloc+0x90/0xc0 mm/kasan/common.c:467 >>   kasan_slab_alloc include/linux/kasan.h:259 [inline] >>   slab_post_alloc_hook mm/slab.h:519 [inline] >>   kmem_cache_alloc_bulk+0x39d/0x720 mm/slub.c:3730 >>   __io_alloc_req_refill fs/io_uring.c:1977 [inline] >>   io_alloc_req_refill fs/io_uring.c:2003 [inline] >>   io_submit_sqes.cold+0x20b/0x43d fs/io_uring.c:7325 >>   __do_sys_io_uring_enter+0xf6e/0x1f50 fs/io_uring.c:10052 >>   do_syscall_x64 arch/x86/entry/common.c:50 [inline] >>   do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 >>   entry_SYSCALL_64_after_hwframe+0x44/0xae >> >> Freed by task 1041: >>   kasan_save_stack+0x1e/0x50 mm/kasan/common.c:38 >>   kasan_set_track+0x21/0x30 mm/kasan/common.c:46 >>   kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:370 >>   ____kasan_slab_free mm/kasan/common.c:366 [inline] >>   ____kasan_slab_free mm/kasan/common.c:328 [inline] >>   __kasan_slab_free+0xff/0x130 mm/kasan/common.c:374 >>   kasan_slab_free include/linux/kasan.h:235 [inline] >>   slab_free_hook mm/slub.c:1723 [inline] >>   slab_free_freelist_hook+0x8b/0x1c0 mm/slub.c:1749 >>   slab_free mm/slub.c:3513 [inline] >>   kmem_cache_free+0x92/0x5e0 mm/slub.c:3529 >>   io_req_caches_free+0x1aa/0x1e6 fs/io_uring.c:9291 >>   io_ring_exit_work+0x1e4/0xbe8 fs/io_uring.c:9467 >>   process_one_work+0x9b2/0x1690 kernel/workqueue.c:2298 >>   worker_thread+0x658/0x11f0 kernel/workqueue.c:2445 >>   kthread+0x405/0x4f0 kernel/kthread.c:327 >>   ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295 >> >> The buggy address belongs to the object at ffff8880713ecb40 >>   which belongs to the cache io_kiocb of size 224 >> The buggy address is located 120 bytes inside of >>   224-byte region [ffff8880713ecb40, ffff8880713ecc20) >> The buggy address belongs to the page: >> page:ffffea0001c4fb00 refcount:1 mapcount:0 mapping:0000000000000000 index:0xffff8880713ec8c0 pfn:0x713ec >> flags: 0xfff00000000200(slab|node=0|zone=1|lastcpupid=0x7ff) >> raw: 00fff00000000200 ffffea0001c4d400 dead000000000004 ffff88814607bdc0 >> raw: ffff8880713ec8c0 00000000800c000b 00000001ffffffff 0000000000000000 >> page dumped because: kasan: bad access detected >> page_owner tracks the page as allocated >> page last allocated via order 0, migratetype Unmovable, gfp_mask 0x12cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY), pid 7168, ts 1580559391621, free_ts 1580537948913 >>   prep_new_page mm/page_alloc.c:2418 [inline] >>   get_page_from_freelist+0xa72/0x2f50 mm/page_alloc.c:4149 >>   __alloc_pages+0x1b2/0x500 mm/page_alloc.c:5369 >>   alloc_pages+0x1a7/0x300 mm/mempolicy.c:2191 >>   alloc_slab_page mm/slub.c:1793 [inline] >>   allocate_slab mm/slub.c:1930 [inline] >>   new_slab+0x32d/0x4a0 mm/slub.c:1993 >>   ___slab_alloc+0x918/0xfe0 mm/slub.c:3022 >>   kmem_cache_alloc_bulk+0x21a/0x720 mm/slub.c:3706 >>   __io_alloc_req_refill fs/io_uring.c:1977 [inline] >>   io_alloc_req_refill fs/io_uring.c:2003 [inline] >>   io_submit_sqes.cold+0x20b/0x43d fs/io_uring.c:7325 >>   __do_sys_io_uring_enter+0xf6e/0x1f50 fs/io_uring.c:10052 >>   do_syscall_x64 arch/x86/entry/common.c:50 [inline] >>   do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 >>   entry_SYSCALL_64_after_hwframe+0x44/0xae >> page last free stack trace: >>   reset_page_owner include/linux/page_owner.h:24 [inline] >>   free_pages_prepare mm/page_alloc.c:1338 [inline] >>   free_pcp_prepare+0x374/0x870 mm/page_alloc.c:1389 >>   free_unref_page_prepare mm/page_alloc.c:3309 [inline] >>   free_unref_page_list+0x1a9/0xfa0 mm/page_alloc.c:3425 >>   release_pages+0x3f4/0x1480 mm/swap.c:979 >>   tlb_batch_pages_flush mm/mmu_gather.c:49 [inline] >>   tlb_flush_mmu_free mm/mmu_gather.c:242 [inline] >>   tlb_flush_mmu mm/mmu_gather.c:249 [inline] >>   tlb_finish_mmu+0x165/0x8c0 mm/mmu_gather.c:340 >>   exit_mmap+0x1ea/0x630 mm/mmap.c:3173 >>   __mmput+0x122/0x4b0 kernel/fork.c:1164 >>   mmput+0x56/0x60 kernel/fork.c:1185 >>   exit_mm kernel/exit.c:507 [inline] >>   do_exit+0xb27/0x2b40 kernel/exit.c:819 >>   do_group_exit+0x125/0x310 kernel/exit.c:929 >>   get_signal+0x47d/0x21d0 kernel/signal.c:2820 >>   arch_do_signal_or_restart+0x2a9/0x1c40 arch/x86/kernel/signal.c:868 >>   handle_signal_work kernel/entry/common.c:148 [inline] >>   exit_to_user_mode_loop kernel/entry/common.c:172 [inline] >>   exit_to_user_mode_prepare+0x17d/0x290 kernel/entry/common.c:207 >>   __syscall_exit_to_user_mode_work kernel/entry/common.c:289 [inline] >>   syscall_exit_to_user_mode+0x19/0x60 kernel/entry/common.c:300 >>   do_syscall_64+0x42/0xb0 arch/x86/entry/common.c:86 >>   entry_SYSCALL_64_after_hwframe+0x44/0xae >> >> Memory state around the buggy address: >>   ffff8880713eca80: fb fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc >>   ffff8880713ecb00: fc fc fc fc fc fc fc fc fa fb fb fb fb fb fb fb >>> ffff8880713ecb80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb >>                                          ^ >>   ffff8880713ecc00: fb fb fb fb fc fc fc fc fc fc fc fc fc fc fc fc >>   ffff8880713ecc80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb >> ================================================================== >> >> >> --- >> This report is generated by a bot. It may contain errors. >> See https://goo.gl/tpsmEJ for more information about syzbot. >> syzbot engineers can be reached at syzkaller@googlegroups.com. >> >> syzbot will keep track of this issue. See: >> https://goo.gl/tpsmEJ#status for how to communicate with syzbot. >> syzbot can test patches for this issue, for details see: >> https://goo.gl/tpsmEJ#testing-patches >> > -- Pavel Begunkov