From: Jens Axboe <axboe@kernel.dk>
To: Govindarajulu Varadarajan <govind.varadar@gmail.com>,
io-uring@vger.kernel.org
Cc: ming.lei@redhat.com, kbusch@kernel.org, hch@lst.de,
sagi@grimberg.me, miklos@szeredi.hu
Subject: Re: [PATCH 1/2] io_uring: Add size check for sqe->cmd
Date: Thu, 29 Jan 2026 13:19:59 -0700 [thread overview]
Message-ID: <ef3a0fd0-d37a-436d-a86c-fe1dc7ec4ccd@kernel.dk> (raw)
In-Reply-To: <20260129201347.411015-2-govind.varadar@gmail.com>
On 1/29/26 1:13 PM, Govindarajulu Varadarajan wrote:
> For SQE128, sqe->cmd provides 80 bytes for uring_cmd. Add macro to
> check if size of user struct does not exceed 80 bytes at compile time.
> User doesn't have to track this manually during development.
>
> Replace io_uring_sqe_cmd() with IO_URING_SQE_CMD() which checks struct
> size for 16 bytes cmd.
Can't we just retain the normal lower case one and add the check? That's
what we do for normal inside sqe data, with io_kiocb_to_cmd(). There
should be no need for all-caps here.
--
Jens Axboe
next prev parent reply other threads:[~2026-01-29 20:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 20:13 [PATCH 0/2] io_uring: Add macro to validate SQE cmd size Govindarajulu Varadarajan
2026-01-29 20:13 ` [PATCH 1/2] io_uring: Add size check for sqe->cmd Govindarajulu Varadarajan
2026-01-29 20:19 ` Jens Axboe [this message]
2026-01-29 20:48 ` Caleb Sander Mateos
2026-01-30 5:11 ` Christoph Hellwig
2026-01-29 20:13 ` [PATCH 2/2] block/ublk_drv: Validate SQE128 flag before accessing the cmd Govindarajulu Varadarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef3a0fd0-d37a-436d-a86c-fe1dc7ec4ccd@kernel.dk \
--to=axboe@kernel.dk \
--cc=govind.varadar@gmail.com \
--cc=hch@lst.de \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=miklos@szeredi.hu \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox