From: Jens Axboe <[email protected]>
To: Pavel Begunkov <[email protected]>, [email protected]
Subject: Re: [RFC net-next v3 1/1] io_uring: fix deadlock on iowq file slot alloc
Date: Wed, 1 Jun 2022 10:29:52 -0600 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <64116172a9d0b85b85300346bb280f3657aafc26.1654087283.git.asml.silence@gmail.com>
On 6/1/22 8:28 AM, Pavel Begunkov wrote:
> io_fixed_fd_install() can grab uring_lock in the slot allocation path
> when called from io-wq, and then call into io_install_fixed_file(),
> which will lock it again. Pull all locking out of
> io_install_fixed_file() into io_fixed_fd_install().
Subject was a little funky for this one, and I had to hand-apply it
since the base was missing that fput fix.
Can you check the end result:
https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.19&id=61c1b44a21d70d4783db02198fbf68b132f4953c
--
Jens Axboe
prev parent reply other threads:[~2022-06-01 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 14:28 [RFC net-next v3 1/1] io_uring: fix deadlock on iowq file slot alloc Pavel Begunkov
2022-06-01 16:29 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox