From: Pavel Begunkov <[email protected]>
To: Colin King <[email protected]>,
Jens Axboe <[email protected]>,
[email protected]
Cc: [email protected], [email protected]
Subject: Re: [PATCH][next] io_uring: Fix uninitialized variable up.resv
Date: Mon, 26 Apr 2021 10:59:13 +0100 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 4/26/21 10:47 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable up.resv is not initialized and is being checking for a
> non-zero value in the call to _io_register_rsrc_update. Fix this by
> explicitly setting the pointer to 0.
LGTM, thanks Colin
> Addresses-Coverity: ("Uninitialized scalar variable)"
> Fixes: c3bdad027183 ("io_uring: add generic rsrc update with tags")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/io_uring.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index f4ec092c23f4..63f610ee274b 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -5842,6 +5842,7 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags)
> up.data = req->rsrc_update.arg;
> up.nr = 0;
> up.tags = 0;
> + up.resv = 0;
>
> mutex_lock(&ctx->uring_lock);
> ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
>
--
Pavel Begunkov
next prev parent reply other threads:[~2021-04-26 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 9:47 [PATCH][next] io_uring: Fix uninitialized variable up.resv Colin King
2021-04-26 9:59 ` Pavel Begunkov [this message]
2021-04-26 10:01 ` Colin Ian King
2021-04-26 10:07 ` Pavel Begunkov
2021-04-26 12:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox