From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="dxC8V38i" Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24FAA106 for ; Sat, 2 Dec 2023 06:58:34 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1cc13149621so8187955ad.1 for ; Sat, 02 Dec 2023 06:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1701529113; x=1702133913; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XW1UgdrkcqxXWOvmhkp24/Qp8+IcQ4Iq6pEPuTKK3Ww=; b=dxC8V38imb/+a0etNuQIX8U5esj6IwLxktmTJ5n1nFq0V0pM8VA98Js8x5QqvKzutE V3Nca2wBqvuArDsfcyZ8MEPWDgnLGlTd633Xuo8Vk4QghRf4Ym/t2PAN8s/Gx1IrxWVr zV1zt7dZddU5KTAgRxDMYqONCKGPV4ySlRFvLgaoxZOLPYFfFnUI63tGffru8lUIS0J7 m2d/LO1DGKxUn4NrTOgtsX39yeKgisZ6zXB30bFVc56kI/44RFfl29IPQcdke2XnckxI n30ea8CA0iK2i9mUqvlr6VHYbVajrO0YExHhQfgC0Bb7LHcmxuBaTNR4kdEkNa8u1lTj DI1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701529113; x=1702133913; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XW1UgdrkcqxXWOvmhkp24/Qp8+IcQ4Iq6pEPuTKK3Ww=; b=dhhk74TthWsAGE7wvWCPUx4OiCZD67w9/3djoS+GymeS6yvtBHPWRxNXdW1+9xH6cW KUT5ib/pdCsLYYsTgGRCsnvMl94ERTC7+w5+epUKz/e5QC1GrZWCQ8UFUEeen8Qkj6RL EvpesYw++uBKH7j3B5j8d2GMukHYem9JUHodwGmB84Id280RrLP515IrauUnOtmz5wMD htPuKpuq6Ay4U5tinOH7QWXKLkWIXjl/yu5pQ56hS/FUtGun6b98LmCX6WIC0BwnO6WS Shnqmr198Dwc5gT8G6jZoQ4dLOUG6IH521NmiMOh+UT3lR8lM6fjFccEppH5EPN/E4q5 ogOw== X-Gm-Message-State: AOJu0YxIRmWCv0zPIStRN4x6WL6fkHM6d5WHzbWq+ZeAcbPb0fnPH1WH u3b02EnS8WbhaP7RkYfhjeViMVO1RwI9efuodzbT8Q== X-Google-Smtp-Source: AGHT+IEdYA1zBSx0/GweJouqcxEpYNoCqs4MttA1Lpvc82tGgIMit/GYbebWL74MRUmEp33KNYAP4g== X-Received: by 2002:a05:6a20:72a3:b0:18b:fece:ff60 with SMTP id o35-20020a056a2072a300b0018bfeceff60mr31298181pzk.1.1701529113460; Sat, 02 Dec 2023 06:58:33 -0800 (PST) Received: from [10.0.0.185] (50-255-6-74-static.hfc.comcastbusiness.net. [50.255.6.74]) by smtp.gmail.com with ESMTPSA id s5-20020a17090aad8500b002853349e490sm6784095pjq.34.2023.12.02.06.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Dec 2023 06:58:32 -0800 (PST) Message-ID: Date: Sat, 2 Dec 2023 07:58:31 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv5 0/4] block integrity: directly map user space addresses Content-Language: en-US To: Kanchan Joshi , Keith Busch Cc: Keith Busch , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, io-uring@vger.kernel.org, hch@lst.de, martin.petersen@oracle.com, ming.lei@redhat.com References: <20231130215309.2923568-1-kbusch@meta.com> <2fe7b3e3-3481-3a67-88f8-13e47ceba545@samsung.com> From: Jens Axboe In-Reply-To: <2fe7b3e3-3481-3a67-88f8-13e47ceba545@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/1/23 7:04 PM, Kanchan Joshi wrote: > On 12/2/2023 7:01 AM, Jens Axboe wrote: >>> Jens already applied the latest series for the next merge. We can append >>> this or fold atop, or back it out and we can rework it for another >>> version. No rush; for your patch: >> I folded this into the original to avoid the breakage, even if it wasn't >> a huge concern for this particular issue. But it's close enough to >> merging, figured we may as well do that rather than have a fixup patch. >> >> Please check the end result, both for-next and for-6.8/block are updated >> now. > > Looks good to me. > May not matter now, so a symbolic > Reviewed-by: Kanchan Joshi It still matters imho, because this thread is linked in the commit. So even for the cases where I don't amend a commit to insert reviewed-bu etc, I still think it's nice to have in the linked thread. Ditto for the fixup - it's referenced in the original commit, and the link will show you what that fixup was. -- Jens Axboe