* Re: [PATCH 01/01] io_uring: Add register support to other PAGE_SIZE [not found] <[email protected]> @ 2021-08-18 13:30 ` Jens Axboe [not found] ` <[email protected]> 0 siblings, 1 reply; 2+ messages in thread From: Jens Axboe @ 2021-08-18 13:30 UTC (permalink / raw) To: wangyangbo; +Cc: asml.silence, io-uring, linux-kernel On 8/17/21 11:56 PM, wangyangbo wrote: > Define rsrc table shift from PAGE_SHIFT This really needs a lot better explanation. A good commit message explains "why" a change is done, this one doesn't have anything really. It briefly tells you "what" is being done, but no reasoning for why. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <[email protected]>]
* Re: [PATCH 1/1] io_uring: Add register support to other PAGE_SIZE [not found] ` <[email protected]> @ 2021-08-19 15:54 ` Jens Axboe 0 siblings, 0 replies; 2+ messages in thread From: Jens Axboe @ 2021-08-19 15:54 UTC (permalink / raw) To: wangyangbo; +Cc: asml.silence, io-uring, linux-kernel, xiehuanjun On 8/18/21 11:56 PM, wangyangbo wrote: > Now allocated rsrc table uses PAGE_SIZE as the size of 2nd-level, and > accessing this table relies on each level index from fixed TABLE_SHIFT > (12 - 3) in 4k page case. In order to correctly work in non-4k page, > define TABLE_SHIFT as non-fixed (PAGE_SHIFT - shift of data) for > 2nd-level table entry number. That's a lot better! Thanks, applied for 5.15. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-19 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <[email protected]>
2021-08-18 13:30 ` [PATCH 01/01] io_uring: Add register support to other PAGE_SIZE Jens Axboe
[not found] ` <[email protected]>
2021-08-19 15:54 ` [PATCH 1/1] " Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox