Re: [External] Re: [PATCH net-next] io_uring/zcrx: fix ifq->if_rxq is -1, get dma_dev is NULL

[Feng Zhou <zhoufeng.zf@bytedance.com>]

在 2025/9/12 20:40, Pavel Begunkov 写道:
> On 9/12/25 09:39, Feng zhou wrote:
>> From: Feng Zhou <zhoufeng.zf@bytedance.com>
>>
>> ifq->if_rxq has not been assigned, is -1, the correct value is
>> in reg.if_rxq.
> 
> Good catch. Note that the blamed patch was merged via the net tree
> this time around to avoid conflicts, and the io_uring tree doesn't
> have it yet. You can repost it adding netdev@vger.kernel.org and
> the net maintainers to be merged via the net tree. Otherwise it'll
> have to wait until 6.18-rc1 is out

Thanks for reminding, will do.

> 
>> Fixes: 59b8b32ac8d469958936fcea781c7f58e3d64742 ("io_uring/zcrx: add 
>> support for custom DMA devices")
>> Signed-off-by: Feng Zhou <zhoufeng.zf@bytedance.com>
>> ---
>>   io_uring/zcrx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
>> index 319eddfd30e0..3639283c87ca 100644
>> --- a/io_uring/zcrx.c
>> +++ b/io_uring/zcrx.c
>> @@ -600,7 +600,7 @@ int io_register_zcrx_ifq(struct io_ring_ctx *ctx,
>>           goto err;
>>       }
>> -    ifq->dev = netdev_queue_get_dma_dev(ifq->netdev, ifq->if_rxq);
>> +    ifq->dev = netdev_queue_get_dma_dev(ifq->netdev, reg.if_rxq);
>>       if (!ifq->dev) {
>>           ret = -EOPNOTSUPP;
>>           goto err;
>