public inbox for [email protected]
 help / color / mirror / Atom feed
* [PATCH] io_uring: rw: Fix an unsigned comparison which can never be negative
@ 2022-09-15  5:49 Jiapeng Chong
  2022-09-15  6:27 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-09-15  5:49 UTC (permalink / raw)
  To: axboe; +Cc: asml.silence, io-uring, linux-kernel, Jiapeng Chong, Abaci Robot

The parameter 'res' is defined as unsigned type, so the following if
statement is invalid, we can modify the type of res to long.
if (res < 0)
  	res = io->bytes_done;
else
  	res += io->bytes_done;

io_uring/rw.c:265 io_fixup_rw_res() warn: unsigned 'res' is never less than zero.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2184
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
 io_uring/rw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/io_uring/rw.c b/io_uring/rw.c
index b777c35378b9..08d88481153c 100644
--- a/io_uring/rw.c
+++ b/io_uring/rw.c
@@ -256,7 +256,7 @@ static bool __io_complete_rw_common(struct io_kiocb *req, long res)
 	return false;
 }
 
-static inline unsigned io_fixup_rw_res(struct io_kiocb *req, unsigned res)
+static inline unsigned io_fixup_rw_res(struct io_kiocb *req, long res)
 {
 	struct io_async_rw *io = req->async_data;
 
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] io_uring: rw: Fix an unsigned comparison which can never be negative
  2022-09-15  5:49 [PATCH] io_uring: rw: Fix an unsigned comparison which can never be negative Jiapeng Chong
@ 2022-09-15  6:27 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2022-09-15  6:27 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: asml.silence, io-uring, linux-kernel, Abaci Robot

On 9/14/22 11:49 PM, Jiapeng Chong wrote:
> The parameter 'res' is defined as unsigned type, so the following if
> statement is invalid, we can modify the type of res to long.
> if (res < 0)
>   	res = io->bytes_done;
> else
>   	res += io->bytes_done;
> 
> io_uring/rw.c:265 io_fixup_rw_res() warn: unsigned 'res' is never less than zero.

This one is already fixed here:

https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-6.0&id=62bb0647b14646fa6c9aa25ecdf67ad18f13523c

-- 
Jens Axboe



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-15  6:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-15  5:49 [PATCH] io_uring: rw: Fix an unsigned comparison which can never be negative Jiapeng Chong
2022-09-15  6:27 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox