From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A14D14A82 for ; Sat, 20 Jan 2024 17:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705770117; cv=none; b=QjR6ovoWR4de9f/MXObxpI62XjYmd3KBUUVf60a1GHGn3Eax6Cmw89wUcnW2S3BOjkpRUzets48VH9ey8sBbzLsiuD/jFEwiET6UAxaQ+oEWyMyPcuAaHCCbni0/Y9VdC9KoFVUgNsGPwnwtW6aEbtf+wiA6WUDUVZAGEv6lHqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705770117; c=relaxed/simple; bh=M0N3JvZSRxhre+AHdg2DAWF69SvD6OJuhG0bltmzIpM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=FDLOu+zSZfzJNxqc/iLgcrhfxzOeItBLYbKIllUmrWatodVBu7ukuCswIBIEGzij4/AH9MqdsW7CRltA8+5YG2sCpBeplRQ4Fs94aXvlF5sjyFk7pUM5iwsqW3bGZNXuUdE2inAA3ftpMIZKNSrJQkf/4Dow+4O3uvGVULURX8E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=H/tjpvfo; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="H/tjpvfo" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5cfb8126375so137135a12.1 for ; Sat, 20 Jan 2024 09:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705770114; x=1706374914; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b8tEllDNlsEDP/jUaFTWEigyTJb7YjOR8aztDaSFSnA=; b=H/tjpvfoMKeZYKpUMTx4G2fK3NqztmyRRAjvNSYjDJgGSa3MKeWGytFUkzJu6my7g1 HRWXUlroSZlimTV/JeqmZseu6WDqa2kbnWaoaQqvVmRVioEuKDvZCPVzk2sIIEOMZ45i U10Zahj/n5Vy4udrpgVrCb7OMIZ5wcGMxDvptC2cOZMyX6DMMhqdnvtMRoCFntqZ2nKM Ywb3UaoDtySKoNKhOloLM6JLJsH6Cai3177fLPucsGl2inO7lX1SA/Nk+mbuH0WWIH/S IkUsCr1PHBDM37149Sd0tvCWzxSlUuUn98woz7kWu+cFzUnVsXDgWsvwBesBfI+J4eh2 Pp1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705770114; x=1706374914; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b8tEllDNlsEDP/jUaFTWEigyTJb7YjOR8aztDaSFSnA=; b=dlqVzYiVsiYdajqk53MGP/mqcyR37PhC3G4HIqCReVD25abGJcancXc1+AbpYcVhbn /Z83h3j1CHejTq0Z9gbsPULnQgvliV/zdSgkVPeQBt6k2vVKdOybYglPh6muGwCBjlqk 3Ox0utxWcDxcF/hJzJr86DvmF+GJkqJl5duG9mv6d8WA/Ih/jAEHWPCaGQE5cR3ZqdJ8 nMuUhp+/hM74B9KC6tAmjF6i5U+kqfUtFKYPmJwHRm305pa7RivqET7u9cnRqCjdAROQ K6sBQ3JmDVejKvACLzIP0mCxtIkbWTuJ4Ed9uEgHf/32MRhpxn/YsYKFfuNs8AcdRyyr 7uVw== X-Gm-Message-State: AOJu0YxcGv1ok4H8Fkry+g2XefycG4F/qjmhO2SinHBdoMbc5Rku0DgQ +t/CKHW+7Wn1uC4dj/XxPLa1WURf+NnY36Tg0N4OBCy48ZgopjMSXprjDulswyA= X-Google-Smtp-Source: AGHT+IFXh+gFqOHeoivxhaztHJcWCZc+b5GjJRb1wA9/OfMKsXYHRO7zmpHOEmQ1l+QFte51U8RP3Q== X-Received: by 2002:a05:6a21:398f:b0:19b:20e9:90da with SMTP id ad15-20020a056a21398f00b0019b20e990damr5256618pzc.5.1705770113640; Sat, 20 Jan 2024 09:01:53 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id fi33-20020a056a0039a100b006d9aa6592d0sm6969907pfb.82.2024.01.20.09.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jan 2024 09:01:53 -0800 (PST) Message-ID: Date: Sat, 20 Jan 2024 10:01:51 -0700 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iouring:added boundary value check for io_uring_group systl Content-Language: en-US To: Subramanya Swamy , corbet@lwn.net, jmoyer@redhat.com, asml.silence@gmail.com, akpm@linux-foundation.org, bhe@redhat.com, ribalda@chromium.org, rostedt@goodmis.org, sshegde@linux.vnet.ibm.com, alexghiti@rivosinc.com, matteorizzo@google.com, ardb@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org References: <20240120144411.2564-1-subramanya.swamy.linux@gmail.com> From: Jens Axboe In-Reply-To: <20240120144411.2564-1-subramanya.swamy.linux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/20/24 7:44 AM, Subramanya Swamy wrote: > /proc/sys/kernel/io_uring_group takes gid as input > added boundary value check to accept gid in range of > 0<=gid<=4294967294 & Documentation is updated for same This should have: Fixes: 76d3ccecfa18 ("io_uring: add a sysctl to disable io_uring system-wide") > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentation/admin-guide/sysctl/kernel.rst > index 6584a1f9bfe3..a8b61ab3e118 100644 > --- a/Documentation/admin-guide/sysctl/kernel.rst > +++ b/Documentation/admin-guide/sysctl/kernel.rst > @@ -470,10 +470,8 @@ io_uring_group > ============== > > When io_uring_disabled is set to 1, a process must either be > -privileged (CAP_SYS_ADMIN) or be in the io_uring_group group in order > -to create an io_uring instance. If io_uring_group is set to -1 (the > -default), only processes with the CAP_SYS_ADMIN capability may create > -io_uring instances. > +privledged (CAP_SYS_ADMIN) or be in the io_uring_group group in order privileged. -- Jens Axboe